Unprefix CSS user-select property

Unprefix CSS user-select property

Parse 'user-select' in the same way as '-webkit-user-select', and make the latter
an alias of the former.

Intent to Ship:https://groups.google.com/a/chromium.org/forum/#!searchin/blink-
dev/user-select/blink-dev/2VWDU83_VzQ/Dw9l33nyAgAJ

BUG=461018
Committed: https://crrev.com/a664cb352ef4e15f7e02ddfe2caae2c6d243a343
Cr-Commit-Position: refs/heads/master@{#413047}

[yoichio, 2016-08-16 06:10:01]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 06:10:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2016-08-16 06:18:35]

Description was changed from

==========
Unprefix user-select

BUG=
==========

to

==========
Unprefix user-select

BUG=461018
==========

[commit-bot: I haz the power, 2016-08-16 07:46:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 07:46:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yoichio, 2016-08-17 05:22:04]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 05:22:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 06:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 06:54:52]

Dry run: This issue passed the CQ dry run.

[yoichio, 2016-08-17 08:44:50]

Description was changed from

==========
Unprefix user-select

BUG=461018
==========

to

==========
Unprefix CSS user-select property

Parse 'user-select' in the same way as '-webkit-user-select', and make the
latter
an alias of the former.

Intent to Ship:https://groups.google.com/a/chromium.org/forum/#!searchin/blink-
dev/user-select/blink-dev/2VWDU83_VzQ/Dw9l33nyAgAJ

BUG=461018
==========

[yoichio, 2016-08-17 08:44:50]

yoichio@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[tkent, 2016-08-17 08:59:43]

https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
(left):

https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt:400:
webkitUserSelect
This means this CL unships element.style.webkitUserSelect property.  Is it safe?
If you have no data to prove it's safe, we need to avoid |alias_for=| in
CSSProperties.in, and follow a case of -webkit-writing-mode and writing-mode.

[yosin_UTC9, 2016-08-17 09:35:29]

https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
(left):

https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt:400:
webkitUserSelect
On 2016/08/17 at 08:59:42, tkent wrote:
> This means this CL unships element.style.webkitUserSelect property.  Is it
safe?
> If you have no data to prove it's safe, we need to avoid |alias_for=| in
CSSProperties.in, and follow a case of -webkit-writing-mode and writing-mode.

I seems we still have |webkitUserSelect| since following test is passed:
test(function () {
  assert_true("webkitUserSelect" in style);
}, "'webkitUserSelect' in style");

[yoichio, 2016-08-18 04:47:49]

On 2016/08/17 09:35:29, Yosi_UTC9 wrote:
>
https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
> (left):
> 
>
https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt:400:
> webkitUserSelect
> On 2016/08/17 at 08:59:42, tkent wrote:
> > This means this CL unships element.style.webkitUserSelect property.  Is it
> safe?
> > If you have no data to prove it's safe, we need to avoid |alias_for=| in
> CSSProperties.in, and follow a case of -webkit-writing-mode and writing-mode.
> 
> I seems we still have |webkitUserSelect| since following test is passed:
> test(function () {
>   assert_true("webkitUserSelect" in style);
> }, "'webkitUserSelect' in style");

I found some strange result:
 foo = document.createElement("foo");
 "webkitUserSelect" in foo.style // true
 for(let p in foo.style){ console.log(p);} // Does not include webkitUserSelect

What does this mean?

[tkent, 2016-08-18 04:53:36]

On 2016/08/18 at 04:47:49, yoichio wrote:
> On 2016/08/17 09:35:29, Yosi_UTC9 wrote:
> >
https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
> > File
> >
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
> > (left):
> > 
> >
https://codereview.chromium.org/2246293003/diff/20001/third_party/WebKit/Layo...
> >
third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt:400:
> > webkitUserSelect
> > On 2016/08/17 at 08:59:42, tkent wrote:
> > > This means this CL unships element.style.webkitUserSelect property.  Is it
> > safe?
> > > If you have no data to prove it's safe, we need to avoid |alias_for=| in
> > CSSProperties.in, and follow a case of -webkit-writing-mode and
writing-mode.
> > 
> > I seems we still have |webkitUserSelect| since following test is passed:
> > test(function () {
> >   assert_true("webkitUserSelect" in style);
> > }, "'webkitUserSelect' in style");
> 
> I found some strange result:
>  foo = document.createElement("foo");
>  "webkitUserSelect" in foo.style // true
>  for(let p in foo.style){ console.log(p);} // Does not include
webkitUserSelect
> 
> What does this mean?

I think it means style.webkitUserSelect exists, but not enumerable.  That's fine
for compatibility risk.  lgtm.

[yosin_UTC9, 2016-08-18 05:25:11]

lgtm

[yoichio, 2016-08-18 06:45:09]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2016-08-18 06:45:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 06:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 06:51:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoichio, 2016-08-18 08:19:06]

yoichio@chromium.org changed reviewers:
+ mpearson@chromium.org

[yoichio, 2016-08-18 08:19:07]

mpearson@, could you review histograms.xml?

[Mark P, 2016-08-18 16:30:06]

histograms.xml lgtm

[yoichio, 2016-08-19 02:12:11]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2016-08-19 02:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 04:16:59]

Description was changed from

==========
Unprefix CSS user-select property

Parse 'user-select' in the same way as '-webkit-user-select', and make the
latter
an alias of the former.

Intent to Ship:https://groups.google.com/a/chromium.org/forum/#!searchin/blink-
dev/user-select/blink-dev/2VWDU83_VzQ/Dw9l33nyAgAJ

BUG=461018
==========

to

==========
Unprefix CSS user-select property

Parse 'user-select' in the same way as '-webkit-user-select', and make the
latter
an alias of the former.

Intent to Ship:https://groups.google.com/a/chromium.org/forum/#!searchin/blink-
dev/user-select/blink-dev/2VWDU83_VzQ/Dw9l33nyAgAJ

BUG=461018
==========

[commit-bot: I haz the power, 2016-08-19 04:17:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 04:18:39]

Description was changed from

==========
Unprefix CSS user-select property

Parse 'user-select' in the same way as '-webkit-user-select', and make the
latter
an alias of the former.

Intent to Ship:https://groups.google.com/a/chromium.org/forum/#!searchin/blink-
dev/user-select/blink-dev/2VWDU83_VzQ/Dw9l33nyAgAJ

BUG=461018
==========

to

==========
Unprefix CSS user-select property

Parse 'user-select' in the same way as '-webkit-user-select', and make the
latter
an alias of the former.

Intent to Ship:https://groups.google.com/a/chromium.org/forum/#!searchin/blink-
dev/user-select/blink-dev/2VWDU83_VzQ/Dw9l33nyAgAJ

BUG=461018

Committed: https://crrev.com/a664cb352ef4e15f7e02ddfe2caae2c6d243a343
Cr-Commit-Position: refs/heads/master@{#413047}
==========

[commit-bot: I haz the power, 2016-08-19 04:18:40]

Patchset 2 (id:??) landed as
https://crrev.com/a664cb352ef4e15f7e02ddfe2caae2c6d243a343
Cr-Commit-Position: refs/heads/master@{#413047}

[Dan Beam, 2017-01-11 23:39:21]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-01-11 23:39:22]

any intent to change -webkit-user-select to user-select in CSS in Chrome?

[yoichio, 2017-01-12 02:11:04]

On 2017/01/11 23:39:22, Dan Beam wrote:
> any intent to change -webkit-user-select to user-select in CSS in Chrome?
Do you mean dashboard?
https://www.chromestatus.com/features/5722186220306432

[tkent, 2017-01-12 02:25:01]

On 2017/01/12 at 02:11:04, yoichio wrote:
> On 2017/01/11 23:39:22, Dan Beam wrote:
> > any intent to change -webkit-user-select to user-select in CSS in Chrome?
> Do you mean dashboard?
> https://www.chromestatus.com/features/5722186220306432

I think Dan meant runprefixing -webkit-user-select usage in Chrome WebUI.
https://cs.chromium.org/search/?q=webkit-user-select+-file:WebKit&sq=package:...

[Dan Beam, 2017-01-12 02:30:43]

On 2017/01/12 02:25:01, tkent wrote:
> On 2017/01/12 at 02:11:04, yoichio wrote:
> > On 2017/01/11 23:39:22, Dan Beam wrote:
> > > any intent to change -webkit-user-select to user-select in CSS in Chrome?
> > Do you mean dashboard?
> > https://www.chromestatus.com/features/5722186220306432
> 
> I think Dan meant runprefixing -webkit-user-select usage in Chrome WebUI.
>
https://cs.chromium.org/search/?q=webkit-user-select+-file:WebKit&sq=package:...

yes, something like this: https://codereview.chromium.org/2621993006/