Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/template-original.cc

Issue 2246263002: Skip parameter replacements where old text != old name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: The fix fixes the new regression test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/template-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/template-original.cc b/tools/clang/rewrite_to_chrome_style/tests/template-original.cc
index b97e8ea2973f87cdfadb5099097b2acab966d0d6..9daff65b9fe138424e8845e582cec054b1cba8db 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/template-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/template-original.cc
@@ -140,4 +140,25 @@ struct Class2 {
} // namespace test_template_arg_is_method_template_in_member_context
+namespace test_unnamed_arg {
+
+template <typename T>
+class Class {
+ public:
+ // Test for https://crbug.com/598141 - shouldn't rewrite
+ // ...int);
+ // into
+ // ...intdata_size;
+ void f(int);
+};
+
+template <typename T>
+void Class<T>::f(int dataSize) {};
+
+void foo() {
+ Class<char>().f(123);
+};
+
+} // namespace test_unnamed_arg
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698