docs/clang_tool_refactoring.md - Issue 2246263002: Skip parameter replacements where old text != old name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: docs/clang_tool_refactoring.md

Issue 2246263002: Skip parameter replacements where old text != old name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: The fix fixes the new regression test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('j') | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: docs/clang_tool_refactoring.md

diff --git a/docs/clang_tool_refactoring.md b/docs/clang_tool_refactoring.md

index ef7faabe97493051af6e0d90a7b7d0625ec6a5e3..5f53ee06a73b1949bfd2a920351814f5a3040d17 100644

--- a/docs/clang_tool_refactoring.md

+++ b/docs/clang_tool_refactoring.md

@@ -112,6 +112,12 @@ Generally, `--tools` should always include `blink_gc_plugin` and `plugins`: othe

It is important to use --bootstrap as there appear to be [bugs](https://crbug.com/580745)

in the clang library this script produces if you build it with gcc, which is the default.

+After bootstrapping is done, rebuilding can be done with something like:

+```shell

+ninja -C third_party/llvm-build/Release+Asserts <tool name>

+```

## Running

First, build all chromium targets to avoid failures due to missing dependecies

that are generated as part of the build:

@@ -172,7 +178,7 @@ that is to `return 1` from the `main()` function of the clang tool.

Synposis:

```shell

-test_tool.py <tool name>

+tools/clang/scripts/test_tool.py <tool name>

```

The name of the tool binary and the subdirectory for the tool in

« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('j') | tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp » ('J')