Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/template-original.cc

Issue 2246263002: Skip parameter replacements where old text != old name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Detecting buggy ParmVarDecls without looking at the source text. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/template-expected.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 namespace not_blink { 5 namespace not_blink {
6 6
7 void function(int x) {} 7 void function(int x) {}
8 8
9 class Class { 9 class Class {
10 public: 10 public:
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 Class c; 133 Class c;
134 c.f(x); 134 c.f(x);
135 // Non-Blink should stay the same. 135 // Non-Blink should stay the same.
136 not_blink::Class c2; 136 not_blink::Class c2;
137 c2.method(x); 137 c2.method(x);
138 } 138 }
139 }; 139 };
140 140
141 } // namespace test_template_arg_is_method_template_in_member_context 141 } // namespace test_template_arg_is_method_template_in_member_context
142 142
143 namespace test_unnamed_arg {
144
145 template <typename T>
146 class Class {
147 public:
148 // Test for https://crbug.com/598141 - shouldn't rewrite
149 // ...int);
150 // into
151 // ...intdata_size;
152 void f(int);
153 };
154
155 template <typename T>
156 void Class<T>::f(int dataSize){};
157
158 void foo() {
159 Class<char>().f(123);
160 };
161
162 } // namespace test_unnamed_arg
163
143 } // namespace blink 164 } // namespace blink
OLDNEW
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/template-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698