Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: net/quic/core/crypto/quic_crypto_server_config.cc

Issue 2246253002: Log info about QUIC inchoate rejects, since we expect to "never" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@130064080
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/quic_crypto_server_config.cc
diff --git a/net/quic/core/crypto/quic_crypto_server_config.cc b/net/quic/core/crypto/quic_crypto_server_config.cc
index 2c843a6161567a2bae47f6bad855c2a3a7dc40e8..8557271c2c762f0086c8eb096b07b2e85b9aab7b 100644
--- a/net/quic/core/crypto/quic_crypto_server_config.cc
+++ b/net/quic/core/crypto/quic_crypto_server_config.cc
@@ -1516,9 +1516,9 @@ void QuicCryptoServerConfig::BuildRejection(
bool should_return_sct =
params->sct_supported_by_client && enable_serving_sct_;
const size_t sct_size = should_return_sct ? crypto_proof.cert_sct.size() : 0;
- if (info.valid_source_address_token ||
- crypto_proof.signature.size() + compressed.size() + sct_size <
- max_unverified_size) {
+ const size_t total_size =
+ crypto_proof.signature.size() + compressed.size() + sct_size;
+ if (info.valid_source_address_token || total_size < max_unverified_size) {
out->SetStringPiece(kCertificateTag, compressed);
out->SetStringPiece(kPROF, crypto_proof.signature);
if (should_return_sct) {
@@ -1528,6 +1528,14 @@ void QuicCryptoServerConfig::BuildRejection(
out->SetStringPiece(kCertificateSCTTag, crypto_proof.cert_sct);
}
}
+ } else {
+ if (FLAGS_quic_use_chlo_packet_size) {
+ DLOG(WARNING)
+ << "Sending inchoate REJ for hostname: " << info.sni
+ << " signature: " << crypto_proof.signature.size()
+ << " cert: " << compressed.size() << " sct:" << sct_size
+ << " total: " << total_size << " max: " << max_unverified_size;
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698