Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.h

Issue 2246233002: [DevTools] Move platform/v8_inspector classes under v8_inspector namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
index 511ec76366bcf50d5018937855e8fa189c6c6bb7..4a146e10fa16866f4cfde99c1eca8c6178e4ed6e 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
@@ -39,6 +39,10 @@
#include "wtf/HashMap.h"
#include "wtf/text/WTFString.h"
+namespace v8_inspector {
+class V8InspectorSession;
+}
+
namespace blink {
class Resource;
@@ -51,7 +55,6 @@ class KURL;
class LocalFrame;
class SharedBuffer;
class TextResourceDecoder;
-class V8InspectorSession;
using blink::protocol::Maybe;
@@ -82,7 +85,7 @@ public:
OtherResource
};
- static InspectorPageAgent* create(InspectedFrames*, Client*, InspectorResourceContentLoader*, V8InspectorSession*);
+ static InspectorPageAgent* create(InspectedFrames*, Client*, InspectorResourceContentLoader*, v8_inspector::V8InspectorSession*);
static HeapVector<Member<Document>> importsForFrame(LocalFrame*);
static bool cachedResourceContent(Resource*, String* result, bool* base64Encoded);
@@ -136,7 +139,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- InspectorPageAgent(InspectedFrames*, Client*, InspectorResourceContentLoader*, V8InspectorSession*);
+ InspectorPageAgent(InspectedFrames*, Client*, InspectorResourceContentLoader*, v8_inspector::V8InspectorSession*);
void finishReload();
void getResourceContentAfterResourcesContentLoaded(const String& frameId, const String& url, std::unique_ptr<GetResourceContentCallback>);
@@ -147,7 +150,7 @@ private:
std::unique_ptr<protocol::Page::Frame> buildObjectForFrame(LocalFrame*);
std::unique_ptr<protocol::Page::FrameResourceTree> buildObjectForFrameTree(LocalFrame*);
Member<InspectedFrames> m_inspectedFrames;
- V8InspectorSession* m_v8Session;
+ v8_inspector::V8InspectorSession* m_v8Session;
Client* m_client;
long m_lastScriptIdentifier;
String m_pendingScriptToEvaluateOnLoadOnce;

Powered by Google App Engine
This is Rietveld 408576698