Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2246223005: Splitting assumenosideeffects Log to webview and chrome (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
Yaron, Torne, xunjieli
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Splitting assumenosideeffects Log to webview and chrome This -assumenosideeffects rule only makes sense for webview and chrome, not in a base flags file which could be used by other clients. BUG=619937 Committed: https://crrev.com/48385972a97bf7a32575bed4d7e200828a1682d6 Cr-Commit-Position: refs/heads/master@{#412834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M android_webview/apk/java/proguard.flags View 1 chunk +9 lines, -0 lines 0 comments Download
M base/android/base_proguard_config.flags View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/android/java/proguard.flags View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
smaier
torne@chromium.org: Please review changes in webview's ProGuard config yfriedman@chromium.org: Please review changes in base's, chrome's ...
4 years, 4 months ago (2016-08-17 19:32:16 UTC) #2
xunjieli
LGTM (though I am not a base OWNER). Thanks for taking care of this!
4 years, 4 months ago (2016-08-17 19:33:38 UTC) #3
Yaron
I guess I'm not sure I understand the reasoning for moving this. Why would another ...
4 years, 4 months ago (2016-08-17 21:12:33 UTC) #4
smaier
On 2016/08/17 21:12:33, Yaron (limited availability) wrote: > I guess I'm not sure I understand ...
4 years, 4 months ago (2016-08-17 21:16:05 UTC) #5
Yaron
On 2016/08/17 21:16:05, smaier wrote: > On 2016/08/17 21:12:33, Yaron (limited availability) wrote: > > ...
4 years, 4 months ago (2016-08-17 22:03:33 UTC) #6
Torne
LGTM, but now that we're splitting these up more and more there's an increasing amount ...
4 years, 4 months ago (2016-08-18 10:09:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246223005/1
4 years, 4 months ago (2016-08-18 14:52:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 15:31:25 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 15:34:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48385972a97bf7a32575bed4d7e200828a1682d6
Cr-Commit-Position: refs/heads/master@{#412834}

Powered by Google App Engine
This is Rietveld 408576698