Splitting assumenosideeffects Log to webview and chrome

Splitting assumenosideeffects Log to webview and chrome

This -assumenosideeffects rule only makes sense for webview and chrome,
not in a base flags file which could be used by other clients.

BUG=619937
Committed: https://crrev.com/48385972a97bf7a32575bed4d7e200828a1682d6
Cr-Commit-Position: refs/heads/master@{#412834}

[smaier, 2016-08-17 19:32:15]

smaier@chromium.org changed reviewers:
+ torne@chromium.org, xunjieli@chromium.org, yfriedman@chromium.org

[smaier, 2016-08-17 19:32:16]

torne@chromium.org: Please review changes in webview's ProGuard config

yfriedman@chromium.org: Please review changes in base's, chrome's ProGuard
config

[xunjieli, 2016-08-17 19:33:38]

LGTM (though I am not a base OWNER). Thanks for taking care of this!

[Yaron, 2016-08-17 21:12:33]

I guess I'm not sure I understand the reasoning for moving this. Why would
another client have issues with logs being removed?

[smaier, 2016-08-17 21:16:05]

On 2016/08/17 21:12:33, Yaron (limited availability) wrote:
> I guess I'm not sure I understand the reasoning for moving this. Why would
> another client have issues with logs being removed?

Some people ship debug and verbose logs to alpha/canary/dogfood customers to
assist with early bug catching.

[Yaron, 2016-08-17 22:03:33]

On 2016/08/17 21:16:05, smaier wrote:
> On 2016/08/17 21:12:33, Yaron (limited availability) wrote:
> > I guess I'm not sure I understand the reasoning for moving this. Why would
> > another client have issues with logs being removed?
> 
> Some people ship debug and verbose logs to alpha/canary/dogfood customers to
> assist with early bug catching.

lgtm

[Torne, 2016-08-18 10:09:17]

LGTM, but now that we're splitting these up more and more there's an increasing
amount of duplication between chrome and webview again.

Could we maybe just introduce a new shared flags file somewhere
(chrome_offical.flags or something) that webview can share?

[smaier, 2016-08-18 14:52:24]

The CQ bit was checked by smaier@chromium.org

[commit-bot: I haz the power, 2016-08-18 14:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 15:31:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 15:34:05]

Description was changed from

==========
Splitting assumenosideeffects Log to webview and chrome

This -assumenosideeffects rule only makes sense for webview and chrome,
not in a base flags file which could be used by other clients.

BUG=619937
==========

to

==========
Splitting assumenosideeffects Log to webview and chrome

This -assumenosideeffects rule only makes sense for webview and chrome,
not in a base flags file which could be used by other clients.

BUG=619937

Committed: https://crrev.com/48385972a97bf7a32575bed4d7e200828a1682d6
Cr-Commit-Position: refs/heads/master@{#412834}
==========

[commit-bot: I haz the power, 2016-08-18 15:34:06]

Patchset 1 (id:??) landed as
https://crrev.com/48385972a97bf7a32575bed4d7e200828a1682d6
Cr-Commit-Position: refs/heads/master@{#412834}