Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 2246223004: Convert fast/events media tests to testharness.js (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert fast/events media tests to testharness.js Cleaning fast/events media tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/e752b76ae114ba886980a5eeea5b03f8e15359bc Cr-Commit-Position: refs/heads/master@{#412547}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use mouseevent to simplify the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html View 1 1 chunk +25 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 4 months ago (2016-08-17 14:14:38 UTC) #3
fs
lgtm https://codereview.chromium.org/2246223004/diff/1/third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html File third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html (right): https://codereview.chromium.org/2246223004/diff/1/third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html#newcode27 third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html:27: click.initMouseEvent("click", true, true, window, 1, 0, 0, 0, ...
4 years, 4 months ago (2016-08-17 14:29:49 UTC) #4
Srirama
https://codereview.chromium.org/2246223004/diff/1/third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html File third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html (right): https://codereview.chromium.org/2246223004/diff/1/third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html#newcode27 third_party/WebKit/LayoutTests/fast/events/media-focus-in-standalone-media-document.html:27: click.initMouseEvent("click", true, true, window, 1, 0, 0, 0, 0, ...
4 years, 4 months ago (2016-08-17 14:45:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246223004/20001
4 years, 4 months ago (2016-08-17 14:49:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 16:12:10 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 16:14:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e752b76ae114ba886980a5eeea5b03f8e15359bc
Cr-Commit-Position: refs/heads/master@{#412547}

Powered by Google App Engine
This is Rietveld 408576698