Refactor fx_font part 1

Split fx_font into multiple files, part 1.

Moved classes CFX_FontCache and CFX_AutoFontCache into a separate file.

Committed: https://pdfium.googlesource.com/pdfium/+/d691899dbff8a8aa024596302fcea1f7d7935252

[npm, 2016-08-15 21:47:40]

Description was changed from

==========
Fix header


Refactor fx_font part 1

BUG=
==========

to

==========
Split fx_font into multiple files, part 1.

Moved classes CFX_FontCache and CFX_AutoFontCache into a separate file.
==========

[npm, 2016-08-15 21:47:40]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-08-15 21:51:12]

PTAL

[npm, 2016-08-16 21:21:58]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:22:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 21:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 21:37:40]

Dry run: Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/1696)
  linux_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel_g...)

[npm, 2016-08-16 21:51:50]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 22:31:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:31:22]

Dry run: This issue passed the CQ dry run.

[npm, 2016-08-17 18:26:53]

Ping

[Lei Zhang, 2016-08-17 18:30:06]

Looks like the Skia bots are red.

[dsinclair, 2016-08-17 18:30:52]

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_fontcache.h (right):

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontcache.h:33: class CFX_AutoFontCache {
Can we move this to cfx_autofontcache.{cpp,h}

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontcache.h:37: ~CFX_AutoFontCache() {
m_pFontCache->ReleaseCachedFace(m_pFont); }
nit: blank line after destructor.

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontcache.h:38: CFX_FontCache* m_pFontCache;
Can these be private?

[npm, 2016-08-17 19:57:35]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:57:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:16:18]

Dry run: This issue passed the CQ dry run.

[npm, 2016-08-17 20:19:21]

PTAL

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_fontcache.h (right):

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontcache.h:33: class CFX_AutoFontCache {
On 2016/08/17 18:30:52, dsinclair wrote:
> Can we move this to cfx_autofontcache.{cpp,h}

Done.

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontcache.h:37: ~CFX_AutoFontCache() {
m_pFontCache->ReleaseCachedFace(m_pFont); }
On 2016/08/17 18:30:52, dsinclair wrote:
> nit: blank line after destructor.

Done.

https://codereview.chromium.org/2246223002/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontcache.h:38: CFX_FontCache* m_pFontCache;
On 2016/08/17 18:30:52, dsinclair wrote:
> Can these be private?

Done.

[dsinclair, 2016-08-17 20:21:51]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-17 20:21:52]

lgtm

[commit-bot: I haz the power, 2016-08-17 20:21:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:22:18]

Description was changed from

==========
Split fx_font into multiple files, part 1.

Moved classes CFX_FontCache and CFX_AutoFontCache into a separate file.
==========

to

==========
Split fx_font into multiple files, part 1.

Moved classes CFX_FontCache and CFX_AutoFontCache into a separate file.

Committed:
https://pdfium.googlesource.com/pdfium/+/d691899dbff8a8aa024596302fcea1f7d793...
==========

[commit-bot: I haz the power, 2016-08-17 20:22:19]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/d691899dbff8a8aa024596302fcea1f7d793...