Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2246203002: Revert of Fix WIC encoder to support kJPEG_Type (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein, mtklein_C
CC:
corey.lucier, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix WIC encoder to support kJPEG_Type (patchset #3 id:140001 of https://codereview.chromium.org/2245453002/ ) Reason for revert: Broken Windows bot. Original issue's description: > Fix WIC encoder to support kJPEG_Type > > (1) Add support for kJPEG to WIC > (2) Add encoding test. > (3) Turn on WIC jpeg encoder on Windows and CG jpeg > encoder on Mac. > > A follow-up may make Skia's encoders the default on all > platforms. But, in order to do that, I think we need > to write better encoding unit tests for CG and WIC. > > BUG=skia:3969 > BUG=skia:5632 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245453002 > > Committed: https://skia.googlesource.com/skia/+/b3a7ef1fc0adc24859d2498aee54d3ec2cbcac3a TBR=mtklein@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3969 Committed: https://skia.googlesource.com/skia/+/93963ba84eed7aca6be3fa5c5445baae0a117ee3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -86 lines) Patch
D gm/encode.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M src/images/SkForceLinking.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkImageEncoder_WIC.cpp View 4 chunks +15 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Fix WIC encoder to support kJPEG_Type
4 years, 4 months ago (2016-08-15 20:52:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246203002/1
4 years, 4 months ago (2016-08-15 20:52:29 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:52:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/93963ba84eed7aca6be3fa5c5445baae0a117ee3

Powered by Google App Engine
This is Rietveld 408576698