Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2246193002: Remove isOpaque from SkSpecialImage, just use alpha type (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove isOpaque from SkSpecialImage, just use alpha type BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246193002 Committed: https://skia.googlesource.com/skia/+/80e96088bc608d6935b24ff623b9025b38da576e

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Make alphaType pure virtual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/core/SkSpecialImage.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSpecialImage.cpp View 4 chunks +4 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Brian Osman
We have isOpaque() on other types, too (including SkImage). It's not clear to me why ...
4 years, 4 months ago (2016-08-15 21:18:59 UTC) #7
Brian Osman
... pure virtual.
4 years, 4 months ago (2016-08-16 13:23:14 UTC) #8
robertphillips
lgtm
4 years, 4 months ago (2016-08-16 13:26:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246193002/40001
4 years, 4 months ago (2016-08-16 13:40:46 UTC) #14
bsalomon
On 2016/08/16 13:40:46, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 4 months ago (2016-08-16 13:52:36 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 14:09:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/80e96088bc608d6935b24ff623b9025b38da576e

Powered by Google App Engine
This is Rietveld 408576698