Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2246173002: Move AnalysisSubView to tr.ui.analysis namespace (Closed)

Created:
4 years, 4 months ago by nduca
Modified:
4 years, 4 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Move AnalysisSubView to tr.ui.analysis namespace We try to have namespace names mirror directories. So, for AnalysisSubView to be in tr.ui.analysis.behaviors, we would want to move it into a behaviors/ folder. That seems like somethign we'd do if we had a lot of behaviors that we needed to keep clearly distinct, which isn't whats happening here. So, this patch moves it to the analysis namespace directly. R=charliea Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d6cad0e105d3bb58b4caab0b8b2d00932c221068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M tracing/tracing/ui/analysis/alert_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/analysis_sub_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/container_memory_dump_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/counter_sample_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_allocator_details_pane.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_header_pane.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_overview_pane.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_vm_regions_details_pane.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_async_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_cpu_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_flow_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_frame_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_instant_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_object_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_power_sample_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_sample_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_thread_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_thread_time_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_user_expectation_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_alert_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_async_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_cpu_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_flow_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_frame_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_instant_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_object_instance_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_object_snapshot_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_power_sample_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_sample_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_thread_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_user_expectation_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/stacked_pane.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nduca
ptal
4 years, 4 months ago (2016-08-15 19:49:40 UTC) #1
charliea (OOO until 10-5)
lgtm. Thanks for moving this! Definitely agree that this is a better home.
4 years, 4 months ago (2016-08-15 19:55:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246173002/1
4 years, 4 months ago (2016-08-15 19:58:12 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 21:58:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698