Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2246163002:
correct comment on GetTabManager (Closed)
|
Created:
4 years, 4 months ago by Anderson Silva Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncorrect comment on GetTabManager
BUG=625662
Committed: https://crrev.com/85932fdc9902666df10cf6f8216b092c3853bcab
Cr-Commit-Position: refs/heads/master@{#412296}
Patch Set 1 #
Total comments: 1
Patch Set 2 : changed comment #Messages
Total messages: 20 (11 generated)
andersoncss@google.com changed reviewers: + chrisha@chromium.org, georgesak@google.com
ptal
ptal
The CQ bit was checked by andersoncss@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== correct comment on GetTabManager BUG=625662 ========== to ========== correct comment on GetTabManager BUG=625662 ==========
andersoncss@google.com changed reviewers: + georgesak@chromium.org - georgesak@google.com
- georgesak@google + georgesak@chromium
https://codereview.chromium.org/2246163002/diff/1/chrome/browser/browser_proc... File chrome/browser/browser_process.h (right): https://codereview.chromium.org/2246163002/diff/1/chrome/browser/browser_proc... chrome/browser/browser_process.h:273: // otherwise. Returns nullptr if invoked from a non-supported platform. I would simplify this, I don't think it's worth mentioning that we create it on the first call: // Returns the tab manager. On non-supported platforms, this returns null.
andersoncss@google.com changed reviewers: + sky@chromium.org
Hi sky, can you please take a look at this CL? We need a owners review. Thanks
LGTM
The CQ bit was checked by andersoncss@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== correct comment on GetTabManager BUG=625662 ========== to ========== correct comment on GetTabManager BUG=625662 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== correct comment on GetTabManager BUG=625662 ========== to ========== correct comment on GetTabManager BUG=625662 Committed: https://crrev.com/85932fdc9902666df10cf6f8216b092c3853bcab Cr-Commit-Position: refs/heads/master@{#412296} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/85932fdc9902666df10cf6f8216b092c3853bcab Cr-Commit-Position: refs/heads/master@{#412296} |
