Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2246143003: Allow opening an offline download file as offline page (Closed)

Created:
4 years, 4 months ago by jianli
Modified:
4 years, 4 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow opening an offline download file as offline page BUG=630817 Committed: https://crrev.com/9b8554ab6bfdb57cdb48e368dce702237c4f01fe Cr-Commit-Position: refs/heads/master@{#412073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jianli
4 years, 4 months ago (2016-08-15 21:43:22 UTC) #2
fgorski
lgtm
4 years, 4 months ago (2016-08-15 21:48:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246143003/1
4 years, 4 months ago (2016-08-15 22:29:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 22:34:20 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 22:36:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b8554ab6bfdb57cdb48e368dce702237c4f01fe
Cr-Commit-Position: refs/heads/master@{#412073}

Powered by Google App Engine
This is Rietveld 408576698