Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: src/codec/SkCodecImageGenerator.cpp

Issue 2246143002: Support color xforms for kIndex8 pngs (Closed) Base URL: https://skia.googlesource.com/skia.git@xformpremul
Patch Set: Response to comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/codec/SkCodecPriv.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkCodecImageGenerator.h" 8 #include "SkCodecImageGenerator.h"
9 9
10 SkImageGenerator* SkCodecImageGenerator::NewFromEncodedCodec(SkData* data) { 10 SkImageGenerator* SkCodecImageGenerator::NewFromEncodedCodec(SkData* data) {
(...skipping 19 matching lines...) Expand all
30 , fData(SkRef(data)) 30 , fData(SkRef(data))
31 {} 31 {}
32 32
33 SkData* SkCodecImageGenerator::onRefEncodedData(SK_REFENCODEDDATA_CTXPARAM) { 33 SkData* SkCodecImageGenerator::onRefEncodedData(SK_REFENCODEDDATA_CTXPARAM) {
34 return SkRef(fData.get()); 34 return SkRef(fData.get());
35 } 35 }
36 36
37 bool SkCodecImageGenerator::onGetPixels(const SkImageInfo& info, void* pixels, s ize_t rowBytes, 37 bool SkCodecImageGenerator::onGetPixels(const SkImageInfo& info, void* pixels, s ize_t rowBytes,
38 SkPMColor ctable[], int* ctableCount) { 38 SkPMColor ctable[], int* ctableCount) {
39 39
40 SkCodec::Result result = fCodec->getPixels(info, pixels, rowBytes, nullptr, ctable, 40 // FIXME (msarett):
41 // We don't give the client the chance to request an SkColorSpace. Until we improve
42 // the API, let's assume that they want legacy mode.
43 SkImageInfo decodeInfo = info.makeColorSpace(nullptr);
44
45 SkCodec::Result result = fCodec->getPixels(decodeInfo, pixels, rowBytes, nul lptr, ctable,
41 ctableCount); 46 ctableCount);
42 switch (result) { 47 switch (result) {
43 case SkCodec::kSuccess: 48 case SkCodec::kSuccess:
44 case SkCodec::kIncompleteInput: 49 case SkCodec::kIncompleteInput:
45 return true; 50 return true;
46 default: 51 default:
47 return false; 52 return false;
48 } 53 }
49 } 54 }
50 55
51 bool SkCodecImageGenerator::onQueryYUV8(SkYUVSizeInfo* sizeInfo, SkYUVColorSpace * colorSpace) const 56 bool SkCodecImageGenerator::onQueryYUV8(SkYUVSizeInfo* sizeInfo, SkYUVColorSpace * colorSpace) const
52 { 57 {
53 return fCodec->queryYUV8(sizeInfo, colorSpace); 58 return fCodec->queryYUV8(sizeInfo, colorSpace);
54 } 59 }
55 60
56 bool SkCodecImageGenerator::onGetYUV8Planes(const SkYUVSizeInfo& sizeInfo, void* planes[3]) { 61 bool SkCodecImageGenerator::onGetYUV8Planes(const SkYUVSizeInfo& sizeInfo, void* planes[3]) {
57 SkCodec::Result result = fCodec->getYUV8Planes(sizeInfo, planes); 62 SkCodec::Result result = fCodec->getYUV8Planes(sizeInfo, planes);
58 63
59 switch (result) { 64 switch (result) {
60 case SkCodec::kSuccess: 65 case SkCodec::kSuccess:
61 case SkCodec::kIncompleteInput: 66 case SkCodec::kIncompleteInput:
62 return true; 67 return true;
63 default: 68 default:
64 return false; 69 return false;
65 } 70 }
66 } 71 }
OLDNEW
« no previous file with comments | « no previous file | src/codec/SkCodecPriv.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698