Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2246113004: [headless] Fix headless_shell compilation. (Closed)

Created:
4 years, 4 months ago by altimin
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Fix headless_shell compilation. - DevTools removed wasThrown from results, use GetExceptionDetails instead. R=skyostil@chromium.org BUG=546953 Committed: https://crrev.com/f7874188bc68911c9fe2ad5d1604169bf99e5ff1 Cr-Commit-Position: refs/heads/master@{#412205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M headless/app/headless_shell.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
altimin
4 years, 4 months ago (2016-08-15 18:22:29 UTC) #1
Sami
lgtm, thanks for the fix.
4 years, 4 months ago (2016-08-16 09:42:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246113004/1
4 years, 4 months ago (2016-08-16 09:43:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 10:25:01 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 10:28:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7874188bc68911c9fe2ad5d1604169bf99e5ff1
Cr-Commit-Position: refs/heads/master@{#412205}

Powered by Google App Engine
This is Rietveld 408576698