SVG: Use counters for SMIL methods on <svg> root element

SVG: Use counters for SMIL methods on <svg> root element

We define two new use counters, to cover the methods defined in
SVGSVGElement.idl

New use counter SVGSMILPausing covers
    void pauseAnimations();
    void unpauseAnimations();
    boolean animationsPaused();

New use counter SVGSMILCurrentTime covers
    float getCurrentTime();
    void setCurrentTime(float seconds);

Committed: https://crrev.com/ab8e0644175ad9e5e3ecd7e9995e997e6f03b480
Cr-Commit-Position: refs/heads/master@{#412669}

[Eric Willigers, 2016-08-15 03:23:08]

ericwilligers@chromium.org changed reviewers:
+ fs@opera.com, kouhei@chromium.org

[Eric Willigers, 2016-08-15 03:23:09]

For SVGAnimationElement use counters see
https://codereview.chromium.org/2243173002/

[Eric Willigers, 2016-08-15 04:58:37]

Updated to use MeasureAs

https://codereview.chromium.org/2246023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGSVGElement.cpp (left):

https://codereview.chromium.org/2246023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGSVGElement.cpp:534:
ASSERT(RuntimeEnabledFeatures::smilEnabled());
These methods are also called by svg/SVGDocumentExtensions.cpp and
svg/graphics/SVGImage.cpp

Running with SMIL disabled currently causes these asserts to fail. (SMIL is
enabled by default.)

[kouhei (in TOK), 2016-08-15 05:00:01]

lgtm

[Eric Willigers, 2016-08-15 05:12:54]

ericwilligers@chromium.org changed reviewers:
+ mkwst@chromium.org

[Eric Willigers, 2016-08-15 05:12:55]

+mkwst for histograms

[Eric Willigers, 2016-08-15 05:13:11]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 05:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 05:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 05:15:07]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eric Willigers, 2016-08-17 02:46:50]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 02:47:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-08-17 02:48:24]

ericwilligers@chromium.org changed reviewers:
+ holte@chromium.org

[Eric Willigers, 2016-08-17 02:48:24]

+holte for histogram OWNERS

[commit-bot: I haz the power, 2016-08-17 04:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 04:46:23]

Dry run: This issue passed the CQ dry run.

[Steven Holte, 2016-08-17 21:59:15]

lgtm

[Eric Willigers, 2016-08-17 22:19:58]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-08-17 22:19:59]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2246023002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-17 22:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 22:25:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 22:29:00]

Description was changed from

==========
SVG: Use counters for SMIL methods on <svg> root element

We define two new use counters, to cover the methods defined in
SVGSVGElement.idl

New use counter SVGSMILPausing covers
    void pauseAnimations();
    void unpauseAnimations();
    boolean animationsPaused();

New use counter SVGSMILCurrentTime covers
    float getCurrentTime();
    void setCurrentTime(float seconds);
==========

to

==========
SVG: Use counters for SMIL methods on <svg> root element

We define two new use counters, to cover the methods defined in
SVGSVGElement.idl

New use counter SVGSMILPausing covers
    void pauseAnimations();
    void unpauseAnimations();
    boolean animationsPaused();

New use counter SVGSMILCurrentTime covers
    float getCurrentTime();
    void setCurrentTime(float seconds);

Committed: https://crrev.com/ab8e0644175ad9e5e3ecd7e9995e997e6f03b480
Cr-Commit-Position: refs/heads/master@{#412669}
==========

[commit-bot: I haz the power, 2016-08-17 22:29:01]

Patchset 3 (id:??) landed as
https://crrev.com/ab8e0644175ad9e5e3ecd7e9995e997e6f03b480
Cr-Commit-Position: refs/heads/master@{#412669}