chrome/browser/ui/views/tabs/tab_strip.cc - Issue 22460011: [CleanUp] Use base::STLSetDifference in place of std::set_difference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 22460011: [CleanUp] Use base::STLSetDifference in place of std::set_difference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | ui/base/test/ui_cocoa_test_helper.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_strip.cc

diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc

index a99257db1107b4e8d8db7022588d26e15df8780d..321fe2cd1497432896b352dc577f1964c72423d4 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.cc

+++ b/chrome/browser/ui/views/tabs/tab_strip.cc

@@ -843,14 +843,10 @@ void TabStrip::SetSelection(const ui::ListSelectionModel& old_selection,

}

- ui::ListSelectionModel::SelectedIndices no_longer_selected;

- std::insert_iterator<ui::ListSelectionModel::SelectedIndices>

- it(no_longer_selected, no_longer_selected.begin());

- std::set_difference(old_selection.selected_indices().begin(),

- old_selection.selected_indices().end(),

- new_selection.selected_indices().begin(),

- new_selection.selected_indices().end(),

- it);

+ ui::ListSelectionModel::SelectedIndices no_longer_selected =

+ base::STLSetDifference<ui::ListSelectionModel::SelectedIndices>(

+ old_selection.selected_indices(),

+ new_selection.selected_indices());

for (size_t i = 0; i < no_longer_selected.size(); ++i)

tab_at(no_longer_selected[i])->StopMiniTabTitleAnimation();

}