chrome/browser/spellchecker/feedback_sender.cc - Issue 22460011: [CleanUp] Use base::STLSetDifference in place of std::set_difference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/feedback_sender.cc

Issue 22460011: [CleanUp] Use base::STLSetDifference in place of std::set_difference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/feedback.cc ('k') | chrome/browser/spellchecker/spellcheck_custom_dictionary.cc » ('j') | ui/base/test/ui_cocoa_test_helper.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/feedback_sender.cc

diff --git a/chrome/browser/spellchecker/feedback_sender.cc b/chrome/browser/spellchecker/feedback_sender.cc

index f8d4957c64efe9ad352c7c3baaa2033b65833572..8943667f175b0551b893541c095acb419f90402a 100644

--- a/chrome/browser/spellchecker/feedback_sender.cc

+++ b/chrome/browser/spellchecker/feedback_sender.cc

@@ -345,12 +345,9 @@ void FeedbackSender::RequestDocumentMarkers() {

// longer alive.

std::vector<int> known_renderers = feedback_.GetRendersWithMisspellings();

std::sort(known_renderers.begin(), known_renderers.end());

- std::vector<int> dead_renderers;

- std::set_difference(known_renderers.begin(),

- known_renderers.end(),

- alive_renderers.begin(),

- alive_renderers.end(),

- std::back_inserter(dead_renderers));

+ std::vector<int> dead_renderers =

+ base::STLSetDifference<std::vector<int> >(known_renderers,

+ alive_renderers);

for (std::vector<int>::const_iterator it = dead_renderers.begin();

it != dead_renderers.end();

++it) {