[SVGDom] Deferred SampleApp parsing

[SVGDom] Deferred SampleApp parsing

Parse SVG files in onOnceBeforeDraw() rather than ctor, to avoid
front-loading a bunch of work when passed a loarge number of SVGs.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245993002

Committed: https://skia.googlesource.com/skia/+/851d68aa5692103db67433354c7421863d01dbda

[f(malita), 2016-08-14 14:03:17]

Description was changed from

==========
[SVGDom] Deferred SampleApp parsing

Parse SVG files in onOnceBeforeDraw() rather than ctor, to avoid
front-loading a bunch of work when passed a loarge number of SVGs.

R=stephana@google.com,robertphillips@google.com
==========

to

==========
[SVGDom] Deferred SampleApp parsing

Parse SVG files in onOnceBeforeDraw() rather than ctor, to avoid
front-loading a bunch of work when passed a loarge number of SVGs.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245993002
==========

[f(malita), 2016-08-14 14:04:29]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 14:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-14 14:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-14 14:24:29]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-14 20:15:29]

lgtm

https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cpp
File samplecode/SampleSVGFile.cpp (right):

https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cp...
samplecode/SampleSVGFile.cpp:25: void onOnceBeforeDraw() override {
Do you need this if check? Shouldn't 'fDom' always be null?

[f(malita), 2016-08-15 13:18:57]

https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cpp
File samplecode/SampleSVGFile.cpp (right):

https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cp...
samplecode/SampleSVGFile.cpp:25: void onOnceBeforeDraw() override {
On 2016/08/14 20:15:29, robertphillips wrote:
> Do you need this if check? Shouldn't 'fDom' always be null?

I was thinking it may trigger when navigating back to a slide, since I've
noticed a bunch of re-parsing when switching back and forth.  I'll double-check
to make sure it does have an impact, and take out if not.

[f(malita), 2016-08-15 14:24:47]

On 2016/08/15 13:18:57, f(malita) wrote:
> https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cpp
> File samplecode/SampleSVGFile.cpp (right):
> 
>
https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cp...
> samplecode/SampleSVGFile.cpp:25: void onOnceBeforeDraw() override {
> On 2016/08/14 20:15:29, robertphillips wrote:
> > Do you need this if check? Shouldn't 'fDom' always be null?
> 
> I was thinking it may trigger when navigating back to a slide, since I've
> noticed a bunch of re-parsing when switching back and forth.  I'll
double-check
> to make sure it does have an impact, and take out if not.

Took it out: it doesn't do anything currently, because unfortunately SampleApp
is caching the factories for SVG/SKP/PDF files - so we get a new instance every
time we visit the slide :(

[f(malita), 2016-08-15 14:24:59]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-15 14:24:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2245993002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-08-15 14:25:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 14:48:50]

Description was changed from

==========
[SVGDom] Deferred SampleApp parsing

Parse SVG files in onOnceBeforeDraw() rather than ctor, to avoid
front-loading a bunch of work when passed a loarge number of SVGs.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245993002
==========

to

==========
[SVGDom] Deferred SampleApp parsing

Parse SVG files in onOnceBeforeDraw() rather than ctor, to avoid
front-loading a bunch of work when passed a loarge number of SVGs.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245993002

Committed:
https://skia.googlesource.com/skia/+/851d68aa5692103db67433354c7421863d01dbda
==========

[commit-bot: I haz the power, 2016-08-15 14:48:51]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/851d68aa5692103db67433354c7421863d01dbda

[robertphillips, 2016-08-15 14:50:38]

On 2016/08/15 14:24:47, f(malita) wrote:
> On 2016/08/15 13:18:57, f(malita) wrote:
> >
https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cpp
> > File samplecode/SampleSVGFile.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2245993002/diff/1/samplecode/SampleSVGFile.cp...
> > samplecode/SampleSVGFile.cpp:25: void onOnceBeforeDraw() override {
> > On 2016/08/14 20:15:29, robertphillips wrote:
> > > Do you need this if check? Shouldn't 'fDom' always be null?
> > 
> > I was thinking it may trigger when navigating back to a slide, since I've
> > noticed a bunch of re-parsing when switching back and forth.  I'll
> double-check
> > to make sure it does have an impact, and take out if not.
> 
> Took it out: it doesn't do anything currently, because unfortunately SampleApp
> is caching the factories for SVG/SKP/PDF files - so we get a new instance
every
> time we visit the slide :(

That's what I thought happened :(