Moved "drawShadowedPicture" call outside of if cases in onDrawContent

Moved "drawShadowedPicture" call outside of if cases in onDrawContent.

Bug description: 
If you updated the view without changing frames (such as moving around the
cursor with 'z' (pixel zoom) on) the window would turn gray.

This was because I left the drawShadowedPicture call inside of the "if-updated"
case inside of SampleShadowing's onDrawContent handler.

If nothing changed and onDrawContent is called, we still need to update the
given canvas's fLights (there is no guarantee of whether the canvas (or its
fLights) has been updated or not), and then draw the shadowed picture.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245923002

Committed: https://skia.googlesource.com/skia/+/d707f2d1cf91505d45edc2d92a7faac788d0d99e

[vjiaoblack, 2016-08-13 15:01:02]

Description was changed from

==========
Moved "drawShadowedPicture" call outside of if cases in onDrawContent

BUG=skia:
==========

to

==========
Moved "drawShadowedPicture" call outside of if cases in onDrawContent

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245923002
==========

[vjiaoblack, 2016-08-13 15:04:38]

vjiaoblack@google.com changed reviewers:
+ jvanverth@google.com, robertphillips@google.com

[vjiaoblack, 2016-08-13 15:04:38]

There was this bug I kept manually fixing in many of my other CLs, but here's a
proper fix.

Bug description: 
If you updated the view without changing frames (such as moving around the
cursor with 'z' (pixel zoom) on) the window would turn gray.

This was because I left the drawShadowedPicture call inside of the "if-updated"
case inside of SampleShadowing's onDrawContent handler.

If nothing changed and onDrawContent is called, we still need to update the
given canvas's fLights (there is no guarantee of whether the canvas (or its
fLights) has been updated or not), and then draw the shadowed picture.

[jvanverth1, 2016-08-16 01:21:35]

On 2016/08/13 15:04:38, vjiaoblack wrote:
> There was this bug I kept manually fixing in many of my other CLs, but here's
a
> proper fix.
> 
> Bug description: 
> If you updated the view without changing frames (such as moving around the
> cursor with 'z' (pixel zoom) on) the window would turn gray.
> 
> This was because I left the drawShadowedPicture call inside of the
"if-updated"
> case inside of SampleShadowing's onDrawContent handler.
> 
> If nothing changed and onDrawContent is called, we still need to update the
> given canvas's fLights (there is no guarantee of whether the canvas (or its
> fLights) has been updated or not), and then draw the shadowed picture.

lgtm

Suggestion: Can you add some of the text above to the CL's description, so it
gets submitted to git? It's useful info.

[vjiaoblack, 2016-08-16 12:18:03]

Description was changed from

==========
Moved "drawShadowedPicture" call outside of if cases in onDrawContent

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245923002
==========

to

==========
Moved "drawShadowedPicture" call outside of if cases in onDrawContent.

Bug description: 
If you updated the view without changing frames (such as moving around the
cursor with 'z' (pixel zoom) on) the window would turn gray.

This was because I left the drawShadowedPicture call inside of the "if-updated"
case inside of SampleShadowing's onDrawContent handler.

If nothing changed and onDrawContent is called, we still need to update the
given canvas's fLights (there is no guarantee of whether the canvas (or its
fLights) has been updated or not), and then draw the shadowed picture.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245923002
==========

[vjiaoblack, 2016-08-16 12:18:35]

The CQ bit was checked by vjiaoblack@google.com

[commit-bot: I haz the power, 2016-08-16 12:18:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 12:38:47]

Description was changed from

==========
Moved "drawShadowedPicture" call outside of if cases in onDrawContent.

Bug description: 
If you updated the view without changing frames (such as moving around the
cursor with 'z' (pixel zoom) on) the window would turn gray.

This was because I left the drawShadowedPicture call inside of the "if-updated"
case inside of SampleShadowing's onDrawContent handler.

If nothing changed and onDrawContent is called, we still need to update the
given canvas's fLights (there is no guarantee of whether the canvas (or its
fLights) has been updated or not), and then draw the shadowed picture.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245923002
==========

to

==========
Moved "drawShadowedPicture" call outside of if cases in onDrawContent.

Bug description: 
If you updated the view without changing frames (such as moving around the
cursor with 'z' (pixel zoom) on) the window would turn gray.

This was because I left the drawShadowedPicture call inside of the "if-updated"
case inside of SampleShadowing's onDrawContent handler.

If nothing changed and onDrawContent is called, we still need to update the
given canvas's fLights (there is no guarantee of whether the canvas (or its
fLights) has been updated or not), and then draw the shadowed picture.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245923002

Committed:
https://skia.googlesource.com/skia/+/d707f2d1cf91505d45edc2d92a7faac788d0d99e
==========

[commit-bot: I haz the power, 2016-08-16 12:38:48]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d707f2d1cf91505d45edc2d92a7faac788d0d99e