Revert of Always enable intermediate source_set.

Revert of Always enable intermediate source_set. (patchset #2 id:20001 of https://codereview.chromium.org/2245513002/ )

Reason for revert:
This is breaking earl grey tests downstream.  I wonder why upstream eg tests aren't on the cq?

Before:
          cmd LC_ID_DYLIB
      cmdsize 64
         name @rpath/EarlGrey.framework/EarlGrey (offset 24)
After:
          cmd LC_ID_DYLIB
      cmdsize 72
         name obj/ios/third_party/earl_grey/x64/EarlGrey (offset 24)

Original issue's description:
> Always enable intermediate source_set.
>
> The _use_intermediate_source_set variable was there to workaround a
> bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
> introduction of an intermediate source_set. Remove the variable and
> consider that it is always set to "true".
>
> BUG=637065
>
> Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
> Cr-Commit-Position: refs/heads/master@{#411779}

TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637065
Committed: https://crrev.com/8bcd27585d5c063b9c19aba05ffe310781181402
Cr-Commit-Position: refs/heads/master@{#411873}

[justincohen, 2016-08-13 03:59:09]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-08-13 03:59:10]

Created Revert of Always enable intermediate source_set.

[commit-bot: I haz the power, 2016-08-13 03:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[justincohen, 2016-08-13 03:59:33]

justincohen@chromium.org changed reviewers:
+ baxley@chromium.org, smut@google.com

[justincohen, 2016-08-13 03:59:33]

Can we get upstream eg tests on the cq?

[justincohen, 2016-08-13 03:59:47]

The CQ bit was unchecked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-08-13 04:00:14]

Description was changed from

==========
Revert of Always enable intermediate source_set. (patchset #2 id:20001 of
https://codereview.chromium.org/2245513002/ )

Reason for revert:
This is breaking earl grey tests downstream.  I wonder why upstream eg tests
aren't on the cq?

Before:
          cmd LC_ID_DYLIB
      cmdsize 64
         name @rpath/EarlGrey.framework/EarlGrey (offset 24)
After:
          cmd LC_ID_DYLIB
      cmdsize 72
         name obj/ios/third_party/earl_grey/x64/EarlGrey (offset 24)

Original issue's description:
> Always enable intermediate source_set.
> 
> The _use_intermediate_source_set variable was there to workaround a
> bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
> introduction of an intermediate source_set. Remove the variable and
> consider that it is always set to "true".
> 
> BUG=637065
> 
> Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
> Cr-Commit-Position: refs/heads/master@{#411779}

TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637065
==========

to

==========
Revert of Always enable intermediate source_set. (patchset #2 id:20001 of
https://codereview.chromium.org/2245513002/ )

Reason for revert:
This is breaking earl grey tests downstream.  I wonder why upstream eg tests
aren't on the cq?

Before:
          cmd LC_ID_DYLIB
      cmdsize 64
         name @rpath/EarlGrey.framework/EarlGrey (offset 24)
After:
          cmd LC_ID_DYLIB
      cmdsize 72
         name obj/ios/third_party/earl_grey/x64/EarlGrey (offset 24)

Original issue's description:
> Always enable intermediate source_set.
> 
> The _use_intermediate_source_set variable was there to workaround a
> bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
> introduction of an intermediate source_set. Remove the variable and
> consider that it is always set to "true".
> 
> BUG=637065
> 
> Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
> Cr-Commit-Position: refs/heads/master@{#411779}

TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637065
==========

[commit-bot: I haz the power, 2016-08-13 04:00:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-13 04:03:34]

Description was changed from

==========
Revert of Always enable intermediate source_set. (patchset #2 id:20001 of
https://codereview.chromium.org/2245513002/ )

Reason for revert:
This is breaking earl grey tests downstream.  I wonder why upstream eg tests
aren't on the cq?

Before:
          cmd LC_ID_DYLIB
      cmdsize 64
         name @rpath/EarlGrey.framework/EarlGrey (offset 24)
After:
          cmd LC_ID_DYLIB
      cmdsize 72
         name obj/ios/third_party/earl_grey/x64/EarlGrey (offset 24)

Original issue's description:
> Always enable intermediate source_set.
> 
> The _use_intermediate_source_set variable was there to workaround a
> bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
> introduction of an intermediate source_set. Remove the variable and
> consider that it is always set to "true".
> 
> BUG=637065
> 
> Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
> Cr-Commit-Position: refs/heads/master@{#411779}

TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637065
==========

to

==========
Revert of Always enable intermediate source_set. (patchset #2 id:20001 of
https://codereview.chromium.org/2245513002/ )

Reason for revert:
This is breaking earl grey tests downstream.  I wonder why upstream eg tests
aren't on the cq?

Before:
          cmd LC_ID_DYLIB
      cmdsize 64
         name @rpath/EarlGrey.framework/EarlGrey (offset 24)
After:
          cmd LC_ID_DYLIB
      cmdsize 72
         name obj/ios/third_party/earl_grey/x64/EarlGrey (offset 24)

Original issue's description:
> Always enable intermediate source_set.
>
> The _use_intermediate_source_set variable was there to workaround a
> bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
> introduction of an intermediate source_set. Remove the variable and
> consider that it is always set to "true".
>
> BUG=637065
>
> Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
> Cr-Commit-Position: refs/heads/master@{#411779}

TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637065

Committed: https://crrev.com/8bcd27585d5c063b9c19aba05ffe310781181402
Cr-Commit-Position: refs/heads/master@{#411873}
==========

[commit-bot: I haz the power, 2016-08-13 04:03:35]

Patchset 1 (id:??) landed as
https://crrev.com/8bcd27585d5c063b9c19aba05ffe310781181402
Cr-Commit-Position: refs/heads/master@{#411873}

[Dirk Pranke, 2016-08-14 23:33:08]

lgtm