Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Don't trust manual new/delete accounting - I hear unique_ptr is a thing.

BUG=637019, 555865
R=cmumford@chromium.org

Committed: https://crrev.com/c93fe49115fd12c42c14bb76e33bd45f728d3358
Cr-Commit-Position: refs/heads/master@{#412226}

[jsbell, 2016-08-12 22:30:55]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-08-12 22:31:20]

cmumford@ - please take a look?

[commit-bot: I haz the power, 2016-08-12 22:32:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 23:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 23:13:37]

Dry run: Exceeded global retry quota

[cmumford, 2016-08-13 00:27:20]

https://codereview.chromium.org/2245833003/diff/1/content/browser/indexed_db/...
File content/browser/indexed_db/indexed_db_backing_store.cc (right):

https://codereview.chromium.org/2245833003/diff/1/content/browser/indexed_db/...
content/browser/indexed_db/indexed_db_backing_store.cc:4032:
incognito_blob_map_[iter.first] = iter.second->Clone();
Does this need to be a std::move()?

[jsbell, 2016-08-16 02:15:38]

Description was changed from

==========
Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Don't trust manual new/delete accounting - I hear unique_ptr is a thing.

BUG=637019
R=cmumford@chromium.org
==========

to

==========
Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Don't trust manual new/delete accounting - I hear unique_ptr is a thing.

BUG=637019,555865
R=cmumford@chromium.org
==========

[jsbell, 2016-08-16 02:49:20]

note to self: I believe the failure is because
IndexedDBBackingStore::Transaction has an implicit copy constructor, and needs
DISALLOW_COPY_AND_ASSIGN

[jsbell, 2016-08-16 03:10:05]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 03:10:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 03:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 03:57:21]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-08-16 05:15:44]

Looks like that did it. cmumford@ - another look?

https://codereview.chromium.org/2245833003/diff/1/content/browser/indexed_db/...
File content/browser/indexed_db/indexed_db_backing_store.cc (right):

https://codereview.chromium.org/2245833003/diff/1/content/browser/indexed_db/...
content/browser/indexed_db/indexed_db_backing_store.cc:4032:
incognito_blob_map_[iter.first] = iter.second->Clone();
On 2016/08/13 00:27:20, cmumford wrote:
> Does this need to be a std::move()?

clang says: "moving a temporary object prevents copy elision"

[cmumford, 2016-08-16 12:11:48]

lgtm

[jsbell, 2016-08-16 13:30:47]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-08-16 13:31:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 13:35:08]

Description was changed from

==========
Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Don't trust manual new/delete accounting - I hear unique_ptr is a thing.

BUG=637019,555865
R=cmumford@chromium.org
==========

to

==========
Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Don't trust manual new/delete accounting - I hear unique_ptr is a thing.

BUG=637019,555865
R=cmumford@chromium.org
==========

[commit-bot: I haz the power, 2016-08-16 13:35:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 13:36:49]

Description was changed from

==========
Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Don't trust manual new/delete accounting - I hear unique_ptr is a thing.

BUG=637019,555865
R=cmumford@chromium.org
==========

to

==========
Indexed DB: Hold BlobChangeRecords in maps using smart pointers

Don't trust manual new/delete accounting - I hear unique_ptr is a thing.

BUG=637019,555865
R=cmumford@chromium.org

Committed: https://crrev.com/c93fe49115fd12c42c14bb76e33bd45f728d3358
Cr-Commit-Position: refs/heads/master@{#412226}
==========

[commit-bot: I haz the power, 2016-08-16 13:36:50]

Patchset 2 (id:??) landed as
https://crrev.com/c93fe49115fd12c42c14bb76e33bd45f728d3358
Cr-Commit-Position: refs/heads/master@{#412226}