Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2245813002:
Round IOSurface sizes to 64 pixels for filter effects. (Closed)
DescriptionRound IOSurface sizes to 64 pixels for filter effects.
This allows IOSurfaces to be more easily reused during resize animations. It
also helps prevent memory fragmentation.
BUG=581526, 636884
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/5d68eb225969d35d6ad1748b3a390e093c02e5eb
Cr-Commit-Position: refs/heads/master@{#412031}
Patch Set 1 #Patch Set 2 : Oops, double allocate. #Patch Set 3 : Round to multiple of 64. #Patch Set 4 : Compile error. #
Total comments: 2
Patch Set 5 : Comments from ccameron. #Messages
Total messages: 23 (16 generated)
Description was changed from ========== Allow more wiggle room when reusing IOSurfaces for filter effects. Creating IOSurfaces is expensive. When trying to reuse an IOSurface for filter effects, allow the IOSurface to be larger than necessary. When creating a new IOSurface, create it at a larger size necessary, so that it can be reused for both scale-up and scale-down animations. BUG=581526, 636884 ========== to ========== Allow more wiggle room when reusing IOSurfaces for filter effects. Creating IOSurfaces is expensive. When trying to reuse an IOSurface for filter effects, allow the IOSurface to be larger than necessary. When creating a new IOSurface, create it at a larger size necessary, so that it can be reused for both scale-up and scale-down animations. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
erikchen@chromium.org changed reviewers: + ccameron@chromium.org
ccameron: Please review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Allow more wiggle room when reusing IOSurfaces for filter effects. Creating IOSurfaces is expensive. When trying to reuse an IOSurface for filter effects, allow the IOSurface to be larger than necessary. When creating a new IOSurface, create it at a larger size necessary, so that it can be reused for both scale-up and scale-down animations. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Round IOSurface sizes to 64 pixels for filter effects. This allows IOSurfaces to be more easily reused during resize animations. It also helps prevent memory fragmentation. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Description was changed from ========== Round IOSurface sizes to 64 pixels for filter effects. This allows IOSurfaces to be more easily reused during resize animations. It also helps prevent memory fragmentation. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Round IOSurface sizes to 64 pixels for filter effects. This allows IOSurfaces to be more easily reused during resize animations. It also helps prevent memory fragmentation. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/12 22:15:52, erikchen wrote: > ccameron: Please review. ccameron: PTAL
lgtm % nit https://codereview.chromium.org/2245813002/diff/60001/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/2245813002/diff/60001/cc/output/gl_renderer.c... cc/output/gl_renderer.cc:3949: uint32_t iosurface_multiple = 64; May be more concise to do updated_dst_rest.set_width( MathUtil::UncheckedRoundUp(updated_dst_rest.width(), iosurface_multiple)); and same for height, from https://cs.chromium.org/chromium/src/cc/base/math_util.h?rcl=1471252828&l=112;
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2245813002/diff/60001/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/2245813002/diff/60001/cc/output/gl_renderer.c... cc/output/gl_renderer.cc:3949: uint32_t iosurface_multiple = 64; On 2016/08/15 18:37:06, ccameron (slow til Sept 1) wrote: > May be more concise to do > updated_dst_rest.set_width( > MathUtil::UncheckedRoundUp(updated_dst_rest.width(), > iosurface_multiple)); > and same for height, from > https://cs.chromium.org/chromium/src/cc/base/math_util.h?rcl=1471252828&l=112; Done, although we can't change updated_dst_rect, since it's parameter are still relevant for setting the viewport.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/2245813002/#ps80001 (title: "Comments from ccameron.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Round IOSurface sizes to 64 pixels for filter effects. This allows IOSurfaces to be more easily reused during resize animations. It also helps prevent memory fragmentation. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Round IOSurface sizes to 64 pixels for filter effects. This allows IOSurfaces to be more easily reused during resize animations. It also helps prevent memory fragmentation. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Round IOSurface sizes to 64 pixels for filter effects. This allows IOSurfaces to be more easily reused during resize animations. It also helps prevent memory fragmentation. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Round IOSurface sizes to 64 pixels for filter effects. This allows IOSurfaces to be more easily reused during resize animations. It also helps prevent memory fragmentation. BUG=581526, 636884 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/5d68eb225969d35d6ad1748b3a390e093c02e5eb Cr-Commit-Position: refs/heads/master@{#412031} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/5d68eb225969d35d6ad1748b3a390e093c02e5eb Cr-Commit-Position: refs/heads/master@{#412031} |
