Simplify and clean up StringTypeAdaptor and StringAppend.

Simplify and clean up StringTypeAdaptor and StringAppend.

BUG=

[esprehn, 2016-08-12 19:25:10]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 19:25:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:35:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[esprehn, 2016-08-12 21:27:42]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 21:28:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-12 21:28:53]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2016-08-12 23:34:39]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 23:35:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 02:58:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 02:58:42]

Dry run: Exceeded global retry quota

[esprehn, 2016-08-13 03:28:32]

esprehn@chromium.org changed reviewers:
+ jyasskin@chromium.org, scottmg@chromium.org

[esprehn, 2016-08-13 03:28:33]

Hey Scott do you understand MSVC? Not sure what I've done here that's producing
different results on clang vs MSVC.

[scottmg, 2016-08-15 15:26:22]

On 2016/08/13 03:28:33, esprehn wrote:
> Hey Scott do you understand MSVC? Not sure what I've done here that's
producing
> different results on clang vs MSVC.

I didn't fully dig in, but from a quick look, I think there's a temporary
getting destroyed that's being held in a StringTypeAdapter.

For example in bool HostIsIPAddress(const String& host)

KURL url(..., protocol + host + "/")

it's using

WTF::operator+<WTF::String>(const WTF::String&, WTF::String)

to add protocol and host. So by the time you're adding the result of those and
"/", the temporary that host was converted to is destroyed.