Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2245763002: Roll DOM Distiller JavaScript distribution package (Closed)

Created:
4 years, 4 months ago by wychen
Modified:
4 years, 4 months ago
Reviewers:
mdjones
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/6c16f14405...91f9f016e0 Picked up changes: 91f9f01 Fix figcaption generation 365c44e Add support for figure element f8f3308 Update distillability modeling scripts to predict long articles 8a12e18 Decrease mismatches in feature extraction 4d7ab13 Extract image URLs in WebTables 8d8063a Extract image URLs in srcset as well 34c4a18 Re-enable tests containing <track> in CI 0d4286b The display style of WebText root element should never be inline BUG=531545, 539851, 595120, 610944, 613374, 625621, 631086, 637170 Committed: https://crrev.com/d1730009565e394ff8c0ad04121d2e44d0c3d166 Cr-Commit-Position: refs/heads/master@{#411811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
wychen
PTAL
4 years, 4 months ago (2016-08-12 19:17:54 UTC) #2
mdjones
lgtm
4 years, 4 months ago (2016-08-12 20:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245763002/1
4 years, 4 months ago (2016-08-12 22:06:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 23:10:44 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 23:15:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1730009565e394ff8c0ad04121d2e44d0c3d166
Cr-Commit-Position: refs/heads/master@{#411811}

Powered by Google App Engine
This is Rietveld 408576698