chrome/browser/profiles/profile_impl_io_data.cc - Issue 2245733004: Serve offline page for online URL on disconnected or bad networks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_impl_io_data.cc

Issue 2245733004: Serve offline page for online URL on disconnected or bad networks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comment in test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper.cc ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_impl_io_data.cc

diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc

index e0c5b22755cb8da241196c2be52ec3bdfb7f25e2..cb3f838153fdbe695fede346ef37c195bac46e06 100644

--- a/chrome/browser/profiles/profile_impl_io_data.cc

+++ b/chrome/browser/profiles/profile_impl_io_data.cc

@@ -69,7 +69,7 @@

#include "storage/browser/quota/special_storage_policy.h"

#if defined(OS_ANDROID)

-#include "chrome/browser/android/offline_pages/offline_page_request_handler.h"

+#include "chrome/browser/android/offline_pages/offline_page_request_interceptor.h"

#endif // defined(OS_ANDROID)

namespace {

@@ -532,11 +532,9 @@ void ProfileImplIOData::InitializeInternal(

// Install the Offline Page Interceptor.

#if defined(OS_ANDROID)

- std::unique_ptr<net::URLRequestInterceptor> offline_page_interceptor =

- offline_pages::OfflinePageRequestHandler::CreateInterceptor(

- profile_params->profile);

- if (offline_page_interceptor)

- request_interceptors.push_back(std::move(offline_page_interceptor));

+ request_interceptors.push_back(std::unique_ptr<net::URLRequestInterceptor>(

+ new offline_pages::OfflinePageRequestInterceptor(

+ profile_params->profile)));

#endif

// The data reduction proxy interceptor should be as close to the network