chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java - Issue 2245733004: Serve offline page for online URL on disconnected or bad networks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2245733004: Serve offline page for online URL on disconnected or bad networks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comment in test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

index 691eac0ce22a5abca126abd6293d2d5a970a5d69..18837301956ec1374f6cfcbfe573dabcefd1bd5c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

@@ -173,12 +173,12 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli

@Override

public void openItem(String guid, @Nullable ComponentName componentName) {

- String url = nativeGetOfflineUrlByGuid(mNativeOfflinePageDownloadBridge, guid);

- if (url == null) return;

+ OfflinePageDownloadItem item = getItem(guid);

+ if (item == null) return;

- LoadUrlParams params = new LoadUrlParams(url);

+ LoadUrlParams params = new LoadUrlParams(item.getUrl());

Map<String, String> headers = new HashMap<String, String>();

- headers.put("X-chromium-offline", "reason=download");

+ headers.put("X-Chrome-offline", "reason=download");

params.setExtraHeaders(headers);

AsyncTabCreationParams asyncParams = componentName == null

? new AsyncTabCreationParams(params)