chrome/chrome_tests_unit.gypi - Issue 2245733004: Serve offline page for online URL on disconnected or bad networks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 2245733004: Serve offline page for online URL on disconnected or bad networks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from dimich Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index abbe8976db81869ef8096e1bffb3a7388bdd7b62..d95e9e696067e978131c04f4e3fe73b910bfbfb4 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -1658,7 +1658,7 @@

# Sources for Offline pages. For now only for Android.

'chrome_unit_tests_offline_pages_sources': [

'browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc',

- 'browser/android/offline_pages/offline_page_tab_helper_unittest.cc',

+ 'browser/android/offline_pages/offline_page_request_job_unittest.cc',

mmenke 2016/08/22 15:12:26 Looks like this is missing from the uploaded CL.

jianli 2016/08/22 23:20:31 Added.

'browser/android/offline_pages/offline_page_utils_unittest.cc',

'browser/android/offline_pages/prerender_adapter_unittest.cc',

'browser/android/offline_pages/prerendering_loader_unittest.cc',

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/test/data/offline_pages/test.mhtml » ('j') | no next file with comments »