chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2245733004: Serve offline page for online URL on disconnected or bad networks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2245733004: Serve offline page for online URL on disconnected or bad networks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address some more feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java ('k') | chrome/browser/android/offline_pages/offline_page_request_handler.h » ('j') | chrome/browser/android/offline_pages/offline_page_request_job.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 2bd6584e614b646016549a656a2b9d68bad4197f..0bb600e94e6a0c2ad9a32fe434e096eb8d623a12 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -2907,12 +2907,9 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

}

/**

- * @return Original url of the tab, if tab currently displays offline copy, would return url of

- * the original page. Otherwise return the original url from DOMDistiller.

+ * @return Original url of the tab, which is the original url from DOMDistiller.

public String getOriginalUrl() {

- OfflinePageItem offlinePage = getOfflinePage();

- if (offlinePage != null) return offlinePage.getUrl();

return DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(getUrl());

}