Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2245733004: Serve offline page for online URL on disconnected or bad networks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address some more feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index a193f6062933b25e4485c783668247e5dab6a733..4ca5e9643470a770218e6627ce0fd0c4934b4e57 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -997,17 +997,12 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
ContentBitmapCallback callback = new ContentBitmapCallback() {
@Override
public void onFinishGetBitmap(Bitmap bitmap, int response) {
- // Check whether this page is an offline page, and use its online URL if so.
- String url = currentTab.getOriginalUrl();
RecordHistogram.recordBooleanHistogram(
- "OfflinePages.SharedPageWasOffline", url != null);
-
- // If there is no entry in the offline pages DB for this tab, use the tab's
- // URL directly.
- if (url == null) url = currentTab.getUrl();
+ "OfflinePages.SharedPageWasOffline", currentTab.isOfflinePage());
ShareHelper.share(
- shareDirectly, mainActivity, currentTab.getTitle(), url, bitmap);
+ shareDirectly, mainActivity, currentTab.getTitle(),
+ currentTab.getUrl(), bitmap);
if (shareDirectly) {
RecordUserAction.record("MobileMenuDirectShare");
} else {

Powered by Google App Engine
This is Rietveld 408576698