Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2245703002: Solaris/OpenBSD/FreeBSD: [heap] Uncommit unused large object page memory. (Closed)

Created:
4 years, 4 months ago by targos
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Solaris/OpenBSD/FreeBSD: [heap] Uncommit unused large object page memory. Port d61a5c376ba51145dc4684e39d5d3a9ce75bcfa6 Original commit message: As a first step I uncommit the memory on the main thread. Also to measure impact and stability of that optimization. In a follow-up CL, the uncommitting should be moved on the concurrent thread. R=jochen@chromium.org, hpayer@chromium.org BUG= Committed: https://crrev.com/38de91a5dae2101b6e70ef50e77defcd211ac4c1 Cr-Commit-Position: refs/heads/master@{#38654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M AUTHORS View 2 chunks +2 lines, -1 line 0 comments Download
M src/base/platform/platform-freebsd.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/base/platform/platform-openbsd.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/base/platform/platform-solaris.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
targos
4 years, 4 months ago (2016-08-12 16:20:24 UTC) #1
ofrobots
On 2016/08/12 16:20:24, targos wrote: lgtm.
4 years, 4 months ago (2016-08-12 20:32:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245703002/1
4 years, 4 months ago (2016-08-13 16:47:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21777)
4 years, 4 months ago (2016-08-13 16:50:24 UTC) #10
Hannes Payer (out of office)
lgtm
4 years, 4 months ago (2016-08-16 11:11:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245703002/1
4 years, 4 months ago (2016-08-16 11:36:24 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 12:00:45 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 12:01:02 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38de91a5dae2101b6e70ef50e77defcd211ac4c1
Cr-Commit-Position: refs/heads/master@{#38654}

Powered by Google App Engine
This is Rietveld 408576698