Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2245653002: Start using vertex attributes for nine-patch blurred rrect draws

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start using vertex attributes for nine-patch blurred rrect draws Calved off: https://codereview.chromium.org/2243133002/ (Pull handling of blurred circles out of GrRRectBlurEffect::Make) https://codereview.chromium.org/2249463002/ (Update blurred rrect mask filter creation method to also handle caching) https://codereview.chromium.org/2248533002/ (Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245653002 Committed: https://skia.googlesource.com/skia/+/087905a730241939da320092543c19dc06d5a7b4

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : update #

Patch Set 4 : update to ToT #

Patch Set 5 : update to ToT #

Patch Set 6 : update to ToT (again) #

Patch Set 7 : clean up #

Patch Set 8 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -46 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 4 5 6 7 5 chunks +65 lines, -46 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
robertphillips
4 years, 4 months ago (2016-08-16 18:15:21 UTC) #10
robertphillips
4 years, 4 months ago (2016-08-16 18:29:05 UTC) #11
bsalomon
lgtm
4 years, 4 months ago (2016-08-16 19:06:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245653002/140001
4 years, 4 months ago (2016-08-16 21:48:36 UTC) #14
commit-bot: I haz the power
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/087905a730241939da320092543c19dc06d5a7b4
4 years, 4 months ago (2016-08-16 21:50:21 UTC) #16
robertphillips
4 years, 4 months ago (2016-08-16 22:49:07 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2250543004/ by robertphillips@google.com.

The reason for reverting is: ??.

Powered by Google App Engine
This is Rietveld 408576698