Support trust anchor constraints, by specifying them as a certificate.

Support trust anchor constraints, by specifying them as a certificate.

BUG=635200, 410574
Committed: https://crrev.com/7f781f34f09fe2f3c5117f71de47e38d9bb59bad
Cr-Commit-Position: refs/heads/master@{#412402}

[eroman, 2016-08-15 23:56:37]

Description was changed from

==========
Support trust anchor constraints, by specifying them as a certificate.

BUG=635200
==========

to

==========
Support trust anchor constraints, by specifying them as a certificate.

BUG=635200,410574
==========

[eroman, 2016-08-16 00:02:15]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2016-08-16 00:03:01]

https://codereview.chromium.org/2245643004/diff/60001/net/cert/internal/verif...
File net/cert/internal/verify_certificate_chain.cc (right):

https://codereview.chromium.org/2245643004/diff/60001/net/cert/internal/verif...
net/cert/internal/verify_certificate_chain.cc:346:
name_constraints_list->push_back(&cert.name_constraints());
I don't yet have a test for this -- will probably do that in a follow-up.

[mattm, 2016-08-16 22:00:06]

lgtm

https://codereview.chromium.org/2245643004/diff/80001/net/data/verify_certifi...
File
net/data/verify_certificate_chain_unittest/generate-expired-unconstrained-root.py
(right):

https://codereview.chromium.org/2245643004/diff/80001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/generate-expired-unconstrained-root.py:9:
enforced."""
missing )

[eroman, 2016-08-16 22:59:12]

Thanks for the review!

Note I removed the changed Cast files from this CL (splitting that off to a
separate CL, since I need to add some more tests for it).

https://codereview.chromium.org/2245643004/diff/80001/net/data/verify_certifi...
File
net/data/verify_certificate_chain_unittest/generate-expired-unconstrained-root.py
(right):

https://codereview.chromium.org/2245643004/diff/80001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/generate-expired-unconstrained-root.py:9:
enforced."""
On 2016/08/16 22:00:06, mattm wrote:
> missing )

Done.

[eroman, 2016-08-16 22:59:35]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:00:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 23:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:10:31]

Dry run: Exceeded global retry quota

[eroman, 2016-08-16 23:31:07]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:32:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 00:29:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:29:42]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-08-17 00:47:19]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-08-17 00:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2245643004/#ps140001
(title: "update gypi")

[commit-bot: I haz the power, 2016-08-17 00:47:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 00:52:05]

Description was changed from

==========
Support trust anchor constraints, by specifying them as a certificate.

BUG=635200,410574
==========

to

==========
Support trust anchor constraints, by specifying them as a certificate.

BUG=635200,410574
==========

[commit-bot: I haz the power, 2016-08-17 00:52:06]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-17 00:53:58]

Description was changed from

==========
Support trust anchor constraints, by specifying them as a certificate.

BUG=635200,410574
==========

to

==========
Support trust anchor constraints, by specifying them as a certificate.

BUG=635200,410574

Committed: https://crrev.com/7f781f34f09fe2f3c5117f71de47e38d9bb59bad
Cr-Commit-Position: refs/heads/master@{#412402}
==========

[commit-bot: I haz the power, 2016-08-17 00:53:59]

Patchset 8 (id:??) landed as
https://crrev.com/7f781f34f09fe2f3c5117f71de47e38d9bb59bad
Cr-Commit-Position: refs/heads/master@{#412402}