sync: Re-implement getAllNodes WebUI function

sync/syncable/directory.h

Index: sync/syncable/directory.h
diff --git a/sync/syncable/directory.h b/sync/syncable/directory.h
index ca8f4f133a72b3a2b95cfbde32688eda3e09d65e..76eec50e1365b45a64cf9e6a91942a2fd8d9ecc7 100644
--- a/sync/syncable/directory.h
+++ b/sync/syncable/directory.h
@@ -327,7 +327,10 @@ class SYNC_EXPORT Directory {
   void CollectMetaHandleCounts(std::vector<int>* num_entries_by_type,
                                std::vector<int>* num_to_delete_entries_by_type);
 
-  scoped_ptr<base::ListValue> GetAllNodeDetails(BaseTransaction* trans);
+  // Returns a ListValue serialization of all nodes for the given type.
+  scoped_ptr<base::ListValue> GetNodeDetailsForType(

[Nicolas Zea, 2014/04/04 23:01:27]

Coupled with the comment about having the DirectoryDebugInfoEmitter handle
multiple types, I think I'd like to see this also handle a ModelTypeSet, to
minimize the number of times we need to invoke this.

+      BaseTransaction* trans,
+      ModelType type);
 
   // Sets the level of invariant checking performed after transactions.
   void SetInvariantCheckLevel(InvariantCheckLevel check_level);