Revert "Simplify ElementVisibilityObserver implementation."

Revert "Simplify ElementVisibilityObserver implementation."

This reverts commit baf0ff22e47eb51e6cd4b0764d771151f7e0500b
(https://codereview.chromium.org/2173353002/).

The reason for this revert is that the previous commit does not
fix the leak and does not provide real benefit to users of
ElementVisibilityObserver.

BUG=627539
Committed: https://crrev.com/8c01587efe00372011ab1aac3987e9937c2da6ce
Cr-Commit-Position: refs/heads/master@{#411622}

[Zhiqiang Zhang (Slow), 2016-08-12 10:33:47]

zqzhang@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, mlamouri@chromium.org,
sigbjornf@opera.com, szager@chromium.org

[Zhiqiang Zhang (Slow), 2016-08-12 10:33:47]

PTAL. As we discussed in the last CL and via email, I'm creating this patch to
revert it.

[Zhiqiang Zhang (Slow), 2016-08-12 10:34:05]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 10:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhiqiang Zhang (Slow), 2016-08-12 10:36:26]

Description was changed from

==========
Revert "Simplify ElementVisibilityObserver implementation."

This reverts commit baf0ff22e47eb51e6cd4b0764d771151f7e0500b.  The
reason for this revert is that the previous commit does not fix the leak
and does not provide real benefit to users of ElementVisibilityObserver.

BUG=627539
==========

to

==========
Revert "Simplify ElementVisibilityObserver implementation."

This reverts commit baf0ff22e47eb51e6cd4b0764d771151f7e0500b
(https://codereview.chromium.org/2173353002/).

The reason for this revert is that the previous commit does not
fix the leak and does not provide real benefit to users of
ElementVisibilityObserver.

BUG=627539
==========

[haraken, 2016-08-12 10:45:55]

LGTM

[commit-bot: I haz the power, 2016-08-12 11:50:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 11:50:40]

Dry run: This issue passed the CQ dry run.

[Zhiqiang Zhang (Slow), 2016-08-12 12:32:33]

sigbjornf, can you PTAL this CL?

The ElementVisibilityObserver issue is blocking other CLs for too long so we
really want to sort things out soon.

[sof, 2016-08-12 12:40:15]

On 2016/08/12 12:32:33, Zhiqiang Zhang wrote:
> sigbjornf, can you PTAL this CL?
> 
> The ElementVisibilityObserver issue is blocking other CLs for too long so we
> really want to sort things out soon.

you have the l*m you need to proceed.

[Zhiqiang Zhang (Slow), 2016-08-12 12:41:53]

On 2016/08/12 12:40:15, sof wrote:
> On 2016/08/12 12:32:33, Zhiqiang Zhang wrote:
> > sigbjornf, can you PTAL this CL?
> > 
> > The ElementVisibilityObserver issue is blocking other CLs for too long so we
> > really want to sort things out soon.
> 
> you have the l*m you need to proceed.

Just to make sure you don't object the revert. Thanks :)

[Zhiqiang Zhang (Slow), 2016-08-12 12:42:33]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-08-12 12:42:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 12:46:22]

Description was changed from

==========
Revert "Simplify ElementVisibilityObserver implementation."

This reverts commit baf0ff22e47eb51e6cd4b0764d771151f7e0500b
(https://codereview.chromium.org/2173353002/).

The reason for this revert is that the previous commit does not
fix the leak and does not provide real benefit to users of
ElementVisibilityObserver.

BUG=627539
==========

to

==========
Revert "Simplify ElementVisibilityObserver implementation."

This reverts commit baf0ff22e47eb51e6cd4b0764d771151f7e0500b
(https://codereview.chromium.org/2173353002/).

The reason for this revert is that the previous commit does not
fix the leak and does not provide real benefit to users of
ElementVisibilityObserver.

BUG=627539
==========

[commit-bot: I haz the power, 2016-08-12 12:46:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 12:49:43]

Description was changed from

==========
Revert "Simplify ElementVisibilityObserver implementation."

This reverts commit baf0ff22e47eb51e6cd4b0764d771151f7e0500b
(https://codereview.chromium.org/2173353002/).

The reason for this revert is that the previous commit does not
fix the leak and does not provide real benefit to users of
ElementVisibilityObserver.

BUG=627539
==========

to

==========
Revert "Simplify ElementVisibilityObserver implementation."

This reverts commit baf0ff22e47eb51e6cd4b0764d771151f7e0500b
(https://codereview.chromium.org/2173353002/).

The reason for this revert is that the previous commit does not
fix the leak and does not provide real benefit to users of
ElementVisibilityObserver.

BUG=627539

Committed: https://crrev.com/8c01587efe00372011ab1aac3987e9937c2da6ce
Cr-Commit-Position: refs/heads/master@{#411622}
==========

[commit-bot: I haz the power, 2016-08-12 12:49:44]

Patchset 1 (id:??) landed as
https://crrev.com/8c01587efe00372011ab1aac3987e9937c2da6ce
Cr-Commit-Position: refs/heads/master@{#411622}