chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc - Issue 2245603003: Add signal strength indicator icon to WebBluetooth chooser on non-Mac desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc

Issue 2245603003: Add signal strength indicator icon to WebBluetooth chooser on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc ('K') | « chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc ('k') | chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.cc » ('j') | chrome/browser/ui/views/chooser_content_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc

diff --git a/chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc b/chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc

index bbb907a809dcb5526f47d7c7ec09d34d3e52139a..3a358272955308a10677dac730c99f2bb4acd93a 100644

--- a/chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc

+++ b/chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc

@@ -6,6 +6,7 @@

#include "base/logging.h"

#include "chrome/browser/ui/bluetooth/bluetooth_chooser_controller.h"

+#include "content/browser/bluetooth/bluetooth_device_chooser_controller.h"

BluetoothChooserDesktop::BluetoothChooserDesktop(

BluetoothChooserController* bluetooth_chooser_controller)

@@ -37,7 +38,9 @@ void BluetoothChooserDesktop::AddOrUpdateDevice(

const int8_t* rssi) {

bluetooth_chooser_controller_->AddOrUpdateDevice(

device_id, should_update_name, device_name, is_gatt_connected, is_paired,

- rssi);

+ rssi ? content::BluetoothDeviceChooserController::

+ CalculateSignalStrengthLevel(*rssi)

+ : -1);

}

void BluetoothChooserDesktop::RemoveDevice(const std::string& device_id) {