Add signal strength indicator icon to WebBluetooth chooser on non-Mac desktops

chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/bluetooth/bluetooth_chooser_controller.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/net/referrer.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/browser/bluetooth/bluetooth_metrics.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
 
 namespace {
 
 Browser* GetBrowser() {
   chrome::ScopedTabbedBrowserDisplayer browser_displayer(
       ProfileManager::GetActiveUserProfile());
   DCHECK(browser_displayer.browser());
   return browser_displayer.browser();
 }
 
+// Anything worse than or equal to this will show 0 bars.
+const int kMinRSSI = -100;
+// Anything better than or equal to this will show the maximum bars.
+const int kMaxRSSI = -55;
+// Number of RSSI levels used in the signal strength icon.
+const int kNumLevels = 5;
+
+int CalculateSignalLevel(int rssi) {

[msw, 2016/08/12 23:08:48]

nit: add a comment, explain the rssi acronym (I had to look it up)

[juncai, 2016/08/15 21:53:19]

Done.

+  if (rssi <= kMinRSSI) {
+    return 0;
+  } else if (rssi >= kMaxRSSI) {

[msw, 2016/08/12 23:08:48]

nit: no else after return here and below.

[juncai, 2016/08/15 21:53:19]

Done.

+    return kNumLevels - 1;
+  } else {
+    double input_range = kMaxRSSI - kMinRSSI;
+    double output_range = kNumLevels - 1;
+    return static_cast<int>(
+        (static_cast<double>(rssi - kMinRSSI) * output_range / input_range));

[msw, 2016/08/12 23:08:48]

nit: you shouldn't need this static cast, right?

[juncai, 2016/08/15 21:53:19]

Done.

+  }
+}
+
 }  // namespace
 
 BluetoothChooserController::BluetoothChooserController(
     content::RenderFrameHost* owner,
     const content::BluetoothChooser::EventHandler& event_handler)
     : ChooserController(owner,
                         IDS_BLUETOOTH_DEVICE_CHOOSER_PROMPT_ORIGIN,
                         IDS_BLUETOOTH_DEVICE_CHOOSER_PROMPT_EXTENSION_NAME),
       event_handler_(event_handler),
       no_devices_text_(l10n_util::GetStringUTF16(
           IDS_BLUETOOTH_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT)) {}
 
 BluetoothChooserController::~BluetoothChooserController() {}
 
+bool BluetoothChooserController::HasIconBeforeText() const {
+  return true;
+}
+
 base::string16 BluetoothChooserController::GetNoOptionsText() const {
   return no_devices_text_;
 }
 
 base::string16 BluetoothChooserController::GetOkButtonLabel() const {
   return l10n_util::GetStringUTF16(
       IDS_BLUETOOTH_DEVICE_CHOOSER_PAIR_BUTTON_TEXT);
 }
 
 size_t BluetoothChooserController::NumOptions() const {
-  return device_ids_.size();
+  return devices_info_.size();
+}
+
+int BluetoothChooserController::GetSignalStrengthLevel(size_t index) const {
+  return devices_info_[index].signal_level;
 }
 
 base::string16 BluetoothChooserController::GetOption(size_t index) const {
-  DCHECK_LT(index, device_ids_.size());
-  const std::string& device_id = device_ids_[index];
+  DCHECK_LT(index, devices_info_.size());
+  const std::string& device_id = devices_info_[index].id;
   const auto& device_name_it = device_id_to_name_map_.find(device_id);
   DCHECK(device_name_it != device_id_to_name_map_.end());
   const auto& it = device_name_map_.find(device_name_it->second);
   DCHECK(it != device_name_map_.end());
   return it->second == 1
              ? device_name_it->second
              : l10n_util::GetStringFUTF16(
                    IDS_DEVICE_CHOOSER_DEVICE_NAME_WITH_ID,
                    device_name_it->second, base::UTF8ToUTF16(device_id));
 }
 
 void BluetoothChooserController::RefreshOptions() {
   if (event_handler_.is_null())
     return;
   ClearAllDevices();
   event_handler_.Run(content::BluetoothChooser::Event::RESCAN, std::string());
 }
 
 base::string16 BluetoothChooserController::GetStatus() const {
   return status_text_;
 }
 
 void BluetoothChooserController::Select(size_t index) {
   if (event_handler_.is_null()) {
     content::RecordRequestDeviceOutcome(
         content::UMARequestDeviceOutcome::
             BLUETOOTH_CHOOSER_EVENT_HANDLER_INVALID);
     return;
   }
-  DCHECK_LT(index, device_ids_.size());
+  DCHECK_LT(index, devices_info_.size());
   event_handler_.Run(content::BluetoothChooser::Event::SELECTED,
-                     device_ids_[index]);
+                     devices_info_[index].id);
 }
 
 void BluetoothChooserController::Cancel() {
   if (event_handler_.is_null())
     return;
   event_handler_.Run(content::BluetoothChooser::Event::CANCELLED,
                      std::string());
 }
 
 void BluetoothChooserController::Close() {
@@ skipping 67 matching lines @@
     bool should_update_name,
     const base::string16& device_name,
     bool is_gatt_connected,
     bool is_paired,
     const int8_t* rssi) {
   auto result = device_id_to_name_map_.insert({device_id, device_name});
   if (!result.second) {
     // TODO(ortuno): Update device's information.
     // https://crbug.com/634366 Update name
     // http://crbug.com/543466 Update connection and paired status
     // http://crbug.com/629689 Update RSSI.

[msw, 2016/08/12 23:08:48]

perhaps consider landing your update CL first, then including the rssi update in
this cl?

[juncai, 2016/08/15 21:53:19]

Yes, I'll land the update device name CL first:
https://codereview.chromium.org/2242943002/
Then modify this CL to include the RSSI update.

     return;
   }
 
-  device_ids_.push_back(device_id);
+  int level = rssi ? CalculateSignalLevel(static_cast<int>(*rssi)) : -1;

[msw, 2016/08/12 23:08:48]

nit: this static cast shouldn't be necessary, right? Maybe CalculateSignalLevel
should take a int8_t?

[juncai, 2016/08/15 21:53:19]

Done.

+  devices_info_.push_back({device_id, level});
   ++device_name_map_[device_name];
   if (view())
-    view()->OnOptionAdded(device_ids_.size() - 1);
+    view()->OnOptionAdded(devices_info_.size() - 1);
 }
 
 void BluetoothChooserController::RemoveDevice(const std::string& device_id) {
   const auto& name_it = device_id_to_name_map_.find(device_id);
   if (name_it == device_id_to_name_map_.end())
     return;
 
   size_t index = 0;
-  for (const auto& saved_device_id : device_ids_) {
-    if (saved_device_id != device_id) {
+  for (const auto& saved_device_info : devices_info_) {
+    if (saved_device_info.id != device_id) {
       ++index;
       continue;
     }
 
-    device_ids_.erase(device_ids_.begin() + index);
+    devices_info_.erase(devices_info_.begin() + index);
 
     const auto& it = device_name_map_.find(name_it->second);
     DCHECK(it != device_name_map_.end());
     DCHECK_GT(it->second, 0);
 
     if (--(it->second) == 0)
       device_name_map_.erase(it);
 
     device_id_to_name_map_.erase(name_it);
 
     if (view())
       view()->OnOptionRemoved(index);
     return;
   }
 }
 
 void BluetoothChooserController::ResetEventHandler() {
   event_handler_.Reset();
 }
 
 void BluetoothChooserController::ClearAllDevices() {
-  device_ids_.clear();
+  devices_info_.clear();
   device_id_to_name_map_.clear();
   device_name_map_.clear();
 }