chrome/browser/ui/webui/snippets_internals_message_handler.cc - Issue 2245583002: Split OfflinePageSuggestions into two categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/snippets_internals_message_handler.cc

Issue 2245583002: Split OfflinePageSuggestions into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedismissed

Patch Set: Marc's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/snippets_internals.html ('k') | components/ntp_snippets/category.h » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/snippets_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/snippets_internals_message_handler.cc b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

index e2705a823f121c2a21fd6ec03915d77a3624b030..4efe2c9738cd61747e432333512923c1a827688b 100644

--- a/chrome/browser/ui/webui/snippets_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

@@ -191,10 +191,15 @@ void SnippetsInternalsMessageHandler::SendAllContent() {

SendBoolean("flag-snippets", base::FeatureList::IsEnabled(

ntp_snippets::kContentSuggestionsFeature));

- SendBoolean("flag-offline-page-suggestions",

+ SendBoolean("flag-recent-offline-tab-suggestions",

base::FeatureList::IsEnabled(

- ntp_snippets::kOfflinePageSuggestionsFeature));

+ ntp_snippets::kRecentOfflineTabSuggestionsFeature));

+ SendBoolean(

+ "flag-download-suggestions",

+ base::FeatureList::IsEnabled(ntp_snippets::kDownloadSuggestionsFeature));

+ SendBoolean(

+ "flag-bookmark-suggestions",

+ base::FeatureList::IsEnabled(ntp_snippets::kBookmarkSuggestionsFeature));

web_ui()->CallJavascriptFunctionUnsafe(

"chrome.SnippetsInternals.setHostRestricted",