Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: components/ntp_snippets/content_suggestions_service_unittest.cc

Issue 2245583002: Split OfflinePageSuggestions into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedismissed
Patch Set: Remove more-button for Recent Tabs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/category_factory.cc ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/content_suggestions_service_unittest.cc
diff --git a/components/ntp_snippets/content_suggestions_service_unittest.cc b/components/ntp_snippets/content_suggestions_service_unittest.cc
index b7ab19a3ffb23991855cd7f97869a6add41a95d7..a7f75386acb4268a0af656e142c1ca04ab12ffdd 100644
--- a/components/ntp_snippets/content_suggestions_service_unittest.cc
+++ b/components/ntp_snippets/content_suggestions_service_unittest.cc
@@ -207,7 +207,7 @@ TEST_F(ContentSuggestionsServiceTest, ShouldRegisterProviders) {
Eq(ContentSuggestionsService::State::ENABLED));
Category articles_category = FromKnownCategory(KnownCategories::ARTICLES);
Category offline_pages_category =
- FromKnownCategory(KnownCategories::OFFLINE_PAGES);
+ FromKnownCategory(KnownCategories::BOOKMARKS);
ASSERT_THAT(providers(), IsEmpty());
EXPECT_THAT(service()->GetCategories(), IsEmpty());
EXPECT_THAT(service()->GetCategoryStatus(articles_category),
@@ -240,7 +240,7 @@ TEST_F(ContentSuggestionsServiceTest, ShouldRegisterProviders) {
TEST_F(ContentSuggestionsServiceDisabledTest, ShouldDoNothingWhenDisabled) {
Category articles_category = FromKnownCategory(KnownCategories::ARTICLES);
Category offline_pages_category =
- FromKnownCategory(KnownCategories::OFFLINE_PAGES);
+ FromKnownCategory(KnownCategories::BOOKMARKS);
EXPECT_THAT(service()->state(),
Eq(ContentSuggestionsService::State::DISABLED));
EXPECT_THAT(providers(), IsEmpty());
@@ -256,7 +256,7 @@ TEST_F(ContentSuggestionsServiceDisabledTest, ShouldDoNothingWhenDisabled) {
TEST_F(ContentSuggestionsServiceTest, ShouldRedirectFetchSuggestionImage) {
Category articles_category = FromKnownCategory(KnownCategories::ARTICLES);
Category offline_pages_category =
- FromKnownCategory(KnownCategories::OFFLINE_PAGES);
+ FromKnownCategory(KnownCategories::BOOKMARKS);
MockProvider* provider1 = MakeProvider(articles_category);
MockProvider* provider2 = MakeProvider(offline_pages_category);
@@ -289,7 +289,7 @@ TEST_F(ContentSuggestionsServiceTest,
TEST_F(ContentSuggestionsServiceTest, ShouldRedirectDismissSuggestion) {
Category articles_category = FromKnownCategory(KnownCategories::ARTICLES);
Category offline_pages_category =
- FromKnownCategory(KnownCategories::OFFLINE_PAGES);
+ FromKnownCategory(KnownCategories::BOOKMARKS);
MockProvider* provider1 = MakeProvider(articles_category);
MockProvider* provider2 = MakeProvider(offline_pages_category);
@@ -304,7 +304,7 @@ TEST_F(ContentSuggestionsServiceTest, ShouldRedirectDismissSuggestion) {
TEST_F(ContentSuggestionsServiceTest, ShouldForwardSuggestions) {
Category articles_category = FromKnownCategory(KnownCategories::ARTICLES);
Category offline_pages_category =
- FromKnownCategory(KnownCategories::OFFLINE_PAGES);
+ FromKnownCategory(KnownCategories::BOOKMARKS);
// Create and register providers
MockProvider* provider1 = MakeProvider(articles_category);
@@ -343,7 +343,7 @@ TEST_F(ContentSuggestionsServiceTest, ShouldForwardSuggestions) {
ExpectThatSuggestionsAre(offline_pages_category, {13, 14});
Mock::VerifyAndClearExpectations(&observer);
- // provider2 reports OFFLINE_PAGES as unavailable
+ // provider2 reports BOOKMARKS as unavailable
EXPECT_CALL(observer, OnCategoryStatusChanged(
offline_pages_category,
CategoryStatus::CATEGORY_EXPLICITLY_DISABLED))
« no previous file with comments | « components/ntp_snippets/category_factory.cc ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698