Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1752)

Unified Diff: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

Issue 2245583002: Split OfflinePageSuggestions into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedismissed
Patch Set: Remove more-button for Recent Tabs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/resources/snippets_internals.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
diff --git a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
index eb891fdf61329d35111030040e2a5d5af0ea3abf..afa227d04c5fe2cf767d77e84fd65eee56f5f3ce 100644
--- a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
+++ b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
@@ -126,15 +126,22 @@ KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(
#if defined(OS_ANDROID)
// Create the OfflinePageSuggestionsProvider.
- if (base::FeatureList::IsEnabled(
- ntp_snippets::kOfflinePageSuggestionsFeature)) {
+ bool recent_tabs_enabled = base::FeatureList::IsEnabled(
+ ntp_snippets::kRecentOfflineTabSuggestionsFeature);
+ bool downloads_enabled =
+ base::FeatureList::IsEnabled(ntp_snippets::kDownloadSuggestionsFeature);
+ bool download_manager_ui_enabled =
+ base::FeatureList::IsEnabled(chrome::android::kDownloadsUiFeature);
+ if (recent_tabs_enabled || downloads_enabled) {
OfflinePageModel* offline_page_model =
OfflinePageModelFactory::GetForBrowserContext(profile);
std::unique_ptr<OfflinePageSuggestionsProvider>
offline_page_suggestions_provider =
base::MakeUnique<OfflinePageSuggestionsProvider>(
- service, service->category_factory(), offline_page_model,
+ recent_tabs_enabled, downloads_enabled,
+ download_manager_ui_enabled, service,
+ service->category_factory(), offline_page_model,
profile->GetPrefs());
service->RegisterProvider(std::move(offline_page_suggestions_provider));
}
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/resources/snippets_internals.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698