chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java - Issue 2245583002: Split OfflinePageSuggestions into two categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java

Issue 2245583002: Split OfflinePageSuggestions into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedismissed

Patch Set: Remove more-button for Recent Tabs Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java

index f144d83b1d5384c12de78dcf24d9d5b7b75a9794..686edb4883d76c608929cd6d98793b97610a23f1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java

@@ -41,9 +41,8 @@ class ActionListItem implements NewTabPageListItem {

int category = mActionListItem.mCategory;

if (category == KnownCategories.BOOKMARKS) {

manager.navigateToBookmarks();

- } else if (category == KnownCategories.OFFLINE_PAGES) {

- // TODO(pke): Implement.

- // org.chromium.chrome.browser.download.DownloadUtils.showDownloadManager

+ } else if (category == KnownCategories.DOWNLOADS) {

+ manager.navigateToDownloadManager();

} else {

// TODO(pke): This should redirect to the C++ backend. Once it does,

// change the condition in the SuggestionsSection constructor.