chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java - Issue 2245583002: Split OfflinePageSuggestions into two categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2245583002: Split OfflinePageSuggestions into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedismissed

Patch Set: More-buttons for the Recent Tabs and Downloads sections Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java ('k') | chrome/app/generated_resources.grd » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

index 5475610e1519dbe6fc068debccdaaea972442fee..e768c34b570547f243b4eb26f83c82f044d19700 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.browser.ntp.cards;

+import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;

import org.chromium.chrome.browser.ntp.snippets.KnownCategories;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticleListItem;

@@ -32,7 +33,14 @@ public class SuggestionsSection implements ItemGroup {

mHeader = new SnippetHeaderListItem(mInfo.getTitle());

// TODO(pke): Replace the condition with "info.hasMoreButton()" once all other categories

// are supported by the C++ backend, too.

- mMoreButton = (category == KnownCategories.BOOKMARKS) ? new ActionListItem(category) : null;

+ // Right now, we hard-code all the sections that are handled in ActionListItem.

+ boolean showMoreButton = false;

+ if (category == KnownCategories.BOOKMARKS || category == KnownCategories.RECENT_TABS) {

+ showMoreButton = true;

+ } else if (category == KnownCategories.DOWNLOADS) {

+ showMoreButton = ChromeFeatureList.isEnabled("DownloadsUi");

+ }

+ mMoreButton = showMoreButton ? new ActionListItem(category) : null;

setSuggestions(suggestions, status, adapter);

}