chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 2245583002: Split OfflinePageSuggestions into two categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2245583002: Split OfflinePageSuggestions into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedismissed

Patch Set: More-buttons for the Recent Tabs and Downloads sections Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 707c5d1c4b2ff1736080907996ae05e4040e019d..db4bd455daa4d2b8af114a1c6ffd5291083b627d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -34,6 +34,7 @@ import org.chromium.chrome.browser.NativePage;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.bookmarks.BookmarkUtils;

import org.chromium.chrome.browser.compositor.layouts.content.InvalidationAwareThumbnailProvider;

+import org.chromium.chrome.browser.download.DownloadUtils;

import org.chromium.chrome.browser.favicon.FaviconHelper;

import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;

import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallback;

@@ -373,6 +374,14 @@ public class NewTabPage

}

@Override

+ public void navigateToDownloadManager() {

+ if (mIsDestroyed) return;

+ assert ChromeFeatureList.isEnabled("DownloadsUi");

+ RecordUserAction.record("MobileNTPSwitchToDownloadManager");

+ DownloadUtils.showDownloadManager(mActivity, mTab);

+ }

+ @Override

public void focusSearchBox(boolean beginVoiceSearch, String pastedText) {

if (mIsDestroyed) return;

if (mFakeboxDelegate != null) {