chrome/browser/about_flags.cc - Issue 2245583002: Split OfflinePageSuggestions into two categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 2245583002: Split OfflinePageSuggestions into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offlinedismissed

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/ntp_snippets/content_suggestions_service_factory.cc » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index e0e50b06dd6cc74c214c72b90cb2062da279c8ab..e1aa8c17599a5db7ebb2a1eb35d93416ce01fb8b 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1286,7 +1286,7 @@ const FeatureEntry kFeatureEntries[] = {

IDS_FLAGS_SHOW_ALL_BOOKMARKS_VIEW_DESCRIPTION, kOsAndroid,

FEATURE_VALUE_TYPE(chrome::android::kAllBookmarksFeature)},

{"enable-downloads-ui", IDS_FLAGS_ENABLE_DOWNLOADS_UI_NAME,

- IDS_FLAGS_ENABLE_DOWNLOADS_UI_DESCRIPTION, kOsAndroid,

+ IDS_FLAGS_ENABLE_DOWNLOADS_UI_DESCRIPTION, kOsAndroid,

FEATURE_VALUE_TYPE(chrome::android::kDownloadsUiFeature)},

{"enable-accessibility-tab-switcher",

IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME,

@@ -1905,10 +1905,15 @@ const FeatureEntry kFeatureEntries[] = {

ntp_snippets::kContentSuggestionsFeature,

kNTPSnippetsFeatureVariations,

ntp_snippets::kStudyName)},

- {"enable-ntp-offline-page-suggestions",

- IDS_FLAGS_ENABLE_NTP_OFFLINE_PAGE_SUGGESTIONS_NAME,

- IDS_FLAGS_ENABLE_NTP_OFFLINE_PAGE_SUGGESTIONS_DESCRIPTION, kOsAndroid,

- FEATURE_VALUE_TYPE(ntp_snippets::kOfflinePageSuggestionsFeature)},

+ {"enable-ntp-recent-offline-tab-suggestions",

+ IDS_FLAGS_ENABLE_NTP_RECENT_OFFLINE_TAB_SUGGESTIONS_NAME,

+ IDS_FLAGS_ENABLE_NTP_RECENT_OFFLINE_TAB_SUGGESTIONS_DESCRIPTION,

+ kOsAndroid,

+ FEATURE_VALUE_TYPE(ntp_snippets::kRecentOfflineTabSuggestionsFeature)},

+ {"enable-ntp-download-suggestions",

+ IDS_FLAGS_ENABLE_NTP_DOWNLOAD_SUGGESTIONS_NAME,

+ IDS_FLAGS_ENABLE_NTP_DOWNLOAD_SUGGESTIONS_DESCRIPTION, kOsAndroid,

+ FEATURE_VALUE_TYPE(ntp_snippets::kDownloadSuggestionsFeature)},

{"enable-ntp-bookmark-suggestions",

IDS_FLAGS_ENABLE_NTP_BOOKMARK_SUGGESTIONS_NAME,

IDS_FLAGS_ENABLE_NTP_BOOKMARK_SUGGESTIONS_DESCRIPTION, kOsAndroid,