Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2245573002: Fix EditingStyle::mergeStyle()'s handling of custom properties (Closed)

Created:
4 years, 4 months ago by Timothy Loh
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix EditingStyle::mergeStyle()'s handling of custom properties This patch fixes the logic of EditingStyle::mergeStyle() to correctly handle custom properties. Currently it serializes the CSSValue and then reparses it, which, aside from being inefficient, doesn't work for custom properties as the custom property name is lost (since we only have the enum value CSSPropertyVariable). BUG=622420 Review-Url: https://codereview.chromium.org/2103043004 Cr-Commit-Position: refs/heads/master@{#410614} (cherry picked from commit aadb63893e4c1358d1e5139aa29552eb190682c8) Committed: https://chromium.googlesource.com/chromium/src/+/ed9e60bc6238f29c78a85229e57a07256c4f66e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/editing/EditingStyleTest.cpp View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Timothy Loh
4 years, 4 months ago (2016-08-12 04:38:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed9e60bc6238f29c78a85229e57a07256c4f66e4.

Powered by Google App Engine
This is Rietveld 408576698