scripts/slave/goma_utils.py - Issue 2245553002: Inherit appropiate environment variables in goma module for goma_utils.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/goma_utils.py

Issue 2245553002: Inherit appropiate environment variables in goma module for goma_utils.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: rename GetGomaTmpDirectory -> GetGomaLogDirectory Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/goma_utils.py

diff --git a/scripts/slave/goma_utils.py b/scripts/slave/goma_utils.py

index 1485300d2419c98feea00853759c1d97ec89cc95..901f2420d13f3e731aec0d74b43aca875550d877 100644

--- a/scripts/slave/goma_utils.py

+++ b/scripts/slave/goma_utils.py

@@ -41,9 +41,9 @@ def GetShortHostname():

return socket.gethostname().split('.')[0].lower()

-def GetGomaTmpDirectory():

+def GetGomaLogDirectory():

"""Get goma's temp directory."""

ukai 2016/08/16 07:21:56 fix doc string as well

tikuta 2016/08/16 07:25:05 Done.

- candidates = ['GOMA_TMP_DIR', 'TEST_TMPDIR', 'TMPDIR', 'TMP']

+ candidates = ['TEST_TMPDIR', 'TMPDIR', 'TMP']

for candidate in candidates:

value = os.environ.get(candidate)

if value and os.path.isdir(value):

@@ -60,7 +60,7 @@ def GetLatestGlogInfoFile(pattern):

Returns:

the latest glog INFO filename in fullpath.

"""

- dirname = GetGomaTmpDirectory()

+ dirname = GetGomaLogDirectory()

info_pattern = os.path.join(dirname, '%s.*.INFO.*' % pattern)

candidates = glob.glob(info_pattern)

if not candidates:

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/goma/api.py » ('j') | no next file with comments »