scripts/slave/recipe_modules/goma/example.expected/linux.json - Issue 2245553002: Inherit appropiate environment variables in goma module for goma_utils.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/linux.json

Issue 2245553002: Inherit appropiate environment variables in goma module for goma_utils.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: use GLOG_log_dir for the location of INFO files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipe_modules/goma/api.py ('k') | scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/goma/example.expected/linux.json

diff --git a/scripts/slave/recipe_modules/goma/example.expected/linux.json b/scripts/slave/recipe_modules/goma/example.expected/linux.json

index 5d8808966bd8ee0f46e32efad5d3b106eaf90539..04634e7274d8b01c825c3bbeb50781264be5954f 100644

--- a/scripts/slave/recipe_modules/goma/example.expected/linux.json

+++ b/scripts/slave/recipe_modules/goma/example.expected/linux.json

@@ -61,6 +61,11 @@

"restart"

"env": {

+ "BUILDBOD_BUILDERNAME": "unknown",

+ "BUILDBOT_CLOBBER": "unknown",

+ "BUILDBOT_MASTERNAME": "unknown",

+ "BUILDBOT_SLAVENAME": "unknown",

+ "GLOG_log_dir": "[TMP_BASE]/goma_tmp_dir_tmp_1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "start_goma"

@@ -73,6 +78,11 @@

"stop"

"env": {

+ "BUILDBOD_BUILDERNAME": "unknown",

+ "BUILDBOT_CLOBBER": "unknown",

+ "BUILDBOT_MASTERNAME": "unknown",

+ "BUILDBOT_SLAVENAME": "unknown",

+ "GLOG_log_dir": "[TMP_BASE]/goma_tmp_dir_tmp_1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "stop_goma"

@@ -84,6 +94,14 @@

"RECIPE_PACKAGE_REPO[build]/scripts/slave/upload_goma_logs.py",

"--upload-compiler-proxy-info"

+ "env": {

+ "BUILDBOD_BUILDERNAME": "unknown",

+ "BUILDBOT_CLOBBER": "unknown",

+ "BUILDBOT_MASTERNAME": "unknown",

+ "BUILDBOT_SLAVENAME": "unknown",

+ "GLOG_log_dir": "[TMP_BASE]/goma_tmp_dir_tmp_1",

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

+ },

"name": "upload_log"

{