scripts/slave/recipe_modules/goma/example.expected/linux.json - Issue 2245553002: Inherit appropiate environment variables in goma module for goma_utils.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/goma/example.expected/linux.json

Issue 2245553002: Inherit appropiate environment variables in goma module for goma_utils.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: remove GOMA_TMP_DIR from goma_utils.py Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipe_modules/goma/api.py ('k') | scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [],	3 "cmd": [],

4 "name": "ensure_goma"	4 "name": "ensure_goma"

5 },	5 },

6 {	6 {

7 "cmd": [	7 "cmd": [

8 "python",	8 "python",

9 "-u",	9 "-u",

10 "RECIPE_MODULE[depot_tools::cipd]/resources/bootstrap.py",	10 "RECIPE_MODULE[depot_tools::cipd]/resources/bootstrap.py",

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 },	77 },

78 "name": "stop_goma"	78 "name": "stop_goma"

79 },	79 },

80 {	80 {

81 "cmd": [	81 "cmd": [

82 "python",	82 "python",

83 "-u",	83 "-u",

84 "RECIPE_PACKAGE_REPO[build]/scripts/slave/upload_goma_logs.py",	84 "RECIPE_PACKAGE_REPO[build]/scripts/slave/upload_goma_logs.py",

85 "--upload-compiler-proxy-info"	85 "--upload-compiler-proxy-info"

86 ],	86 ],

	87 "env": {

	88 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	89 },

87 "name": "upload_log"	90 "name": "upload_log"

88 },	91 },

89 {	92 {

90 "name": "$result",	93 "name": "$result",

91 "recipe_result": null,	94 "recipe_result": null,

92 "status_code": 0	95 "status_code": 0

93 }	96 }

94 ]	97 ]

OLD	NEW