Removal of grammar-checking-related dead code

Removal of grammar-checking-related dead code

This patch removes the following dead functions:
- static findBadGrammars() from TextCheckingHelper.cpp
- TextCheckerClient::checkGrammarOfString
- TextCheckingHelper::findFirstBadGrammar
- TextCheckingHelper::findFirstGrammarDetail
- TextCheckingHelper::markAllBadGrammar

This patch also does some follow-up cleanup to:
- SpellChecker::advanceToNextMisspelling
- TextCheckingHelper::findFirstMisspellingOrBadGrammar
- static checkTextOfParagraph() and FindMisspellings() in TextCheckingHelper.cpp

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09
Cr-Commit-Position: refs/heads/master@{#411557}

[Xiaocheng, 2016-08-12 03:38:05]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 03:38:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-12 04:40:22]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-08-12 04:40:23]

PTAL.

[yosin_UTC9, 2016-08-12 05:05:22]

lgtm

https://codereview.chromium.org/2245543003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
(right):

https://codereview.chromium.org/2245543003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h:92:
String findFirstMisspellingOrBadGrammar(int& outFirstFoundOffset);
Optional: Could you add TODO for returning tuple of String and int rather than
using output parameter? Just use std::pair<String, int> in another patch?

[Xiaocheng, 2016-08-12 05:08:18]

On 2016/08/12 at 05:05:22, yosin wrote:
> lgtm
> 
>
https://codereview.chromium.org/2245543003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
(right):
> 
>
https://codereview.chromium.org/2245543003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h:92:
String findFirstMisspellingOrBadGrammar(int& outFirstFoundOffset);
> Optional: Could you add TODO for returning tuple of String and int rather than
using output parameter? Just use std::pair<String, int> in another patch?

Sure, I'll do it in a follow-up patch.

In fact I'm preparing to remove TextCheckingHelper. The class will become
basically useless after cleaning up code related to unified text checker. The
way of passing return value can be changed then.

[tkent, 2016-08-12 05:12:59]

lgtm

[commit-bot: I haz the power, 2016-08-12 05:21:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 05:21:33]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-12 05:33:38]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-12 05:33:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 05:36:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 05:37:53]

Description was changed from

==========
Removal of grammar-checking-related dead code

This patch removes the following dead functions:
- static findBadGrammars() from TextCheckingHelper.cpp
- TextCheckerClient::checkGrammarOfString
- TextCheckingHelper::findFirstBadGrammar
- TextCheckingHelper::findFirstGrammarDetail
- TextCheckingHelper::markAllBadGrammar

This patch also does some follow-up cleanup to:
- SpellChecker::advanceToNextMisspelling
- TextCheckingHelper::findFirstMisspellingOrBadGrammar
- static checkTextOfParagraph() and FindMisspellings() in TextCheckingHelper.cpp

BUG=619452
TEST=n/a; no behavior change
==========

to

==========
Removal of grammar-checking-related dead code

This patch removes the following dead functions:
- static findBadGrammars() from TextCheckingHelper.cpp
- TextCheckerClient::checkGrammarOfString
- TextCheckingHelper::findFirstBadGrammar
- TextCheckingHelper::findFirstGrammarDetail
- TextCheckingHelper::markAllBadGrammar

This patch also does some follow-up cleanup to:
- SpellChecker::advanceToNextMisspelling
- TextCheckingHelper::findFirstMisspellingOrBadGrammar
- static checkTextOfParagraph() and FindMisspellings() in TextCheckingHelper.cpp

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09
Cr-Commit-Position: refs/heads/master@{#411557}
==========

[commit-bot: I haz the power, 2016-08-12 05:37:54]

Patchset 1 (id:??) landed as
https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09
Cr-Commit-Position: refs/heads/master@{#411557}